From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: [core-updates] Should we patch icu4c? Date: Sun, 21 Jul 2019 17:02:04 +0200 Message-ID: <874l3f5t3n.fsf@devup.no> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:44113) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpDVi-000309-Pi for guix-devel@gnu.org; Sun, 21 Jul 2019 11:12:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpDVh-00047e-5H for guix-devel@gnu.org; Sun, 21 Jul 2019 11:12:26 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:38523) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hpDVg-00041u-RB for guix-devel@gnu.org; Sun, 21 Jul 2019 11:12:25 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 5048E21B81 for ; Sun, 21 Jul 2019 11:02:07 -0400 (EDT) Received: from localhost (140.226.16.62.customer.cdi.no [62.16.226.140]) by mail.messagingengine.com (Postfix) with ESMTPA id A7F0980061 for ; Sun, 21 Jul 2019 11:02:06 -0400 (EDT) List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Node's "parallel/test-intl" fails on the 'core-updates' branch when built for i686-linux: =2D-8<---------------cut here---------------start------------->8--- not ok 1254 parallel/test-intl --- duration_ms: 1.308 severity: fail exitcode: 1 stack: |- assert.js:738 throw newErr; ^ =20=20=20=20 AssertionError [ERR_ASSERTION]: ifError got unwanted exception: Command= failed: /tmp/guix-build-node-10.16.0.drv-0/node-v10.16.0/out/Release/node = -p new Intl.NumberFormat().resolvedOptions().locale munmap_chunk(): invalid pointer =20=20=20=20 at ChildProcess.exithandler (child_process.js:294:12) at ChildProcess.emit (events.js:198:13) at maybeClose (internal/child_process.js:982:16) at Process.ChildProcess._handle.onexit (internal/child_process.js:2= 59:5) ... =2D-8<---------------cut here---------------end--------------->8--- This is a regression test for a problem in ICU 64: https://github.com/nodejs/node/blob/v10.16.0/test/parallel/test-intl.js#L141 https://unicode-org.atlassian.net/browse/ICU-20575 Apparently the V8 workaround only works on 64-bit? The test succeeds if I build Node with a patched ICU: =2D-8<---------------cut here---------------start------------->8--- (define %icu4c-patches (list (origin (method url-fetch) (uri (string-append "https://github.com/unicode-org/icu/commit/" "7788f04eb9be0d7ecade6af46cf7b9825447763d.pat= ch")) (file-name "icu4c-datetime-regression.patch") (sha256 (base32 "0gs2sbdfpzwwdjqcqr0c16fw3g7wy3gb1gbgvzs9k1ciw0bhpv4w"))) (origin (method url-fetch) (uri (string-append "https://github.com/unicode-org/icu/commit/" "cfb20862909ff105d4f2c43923c97561bc5a5815.pat= ch")) (file-name "icu4c-locale-mapping.patch") (sha256 (base32 "0s5psb60aisj6icziblvlp9dqcz56n3887i8ib0yidbjnnrw5b97"))))) =2D-8<---------------cut here---------------end--------------->8--- The last patch is sufficient to fix this problem, but the other seems nice to have. They are taken from the upstream "maint-64" branch: https://github.com/unicode-org/icu/commits/maint/maint-64 I suspect the locale issue will show up in more packages as we go. Patching ICU is a good opportunity to fix these issues: https://issues.guix.gnu.org/issue/36721 https://issues.guix.gnu.org/issue/36722 ...since they would not add to the ~50% rebuild count and armhf still has not gotten this far. Any volunteers for the second issue (add Python 3 support to Boost)? CMake experts are welcome to join me in the first quest on #guix :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl00fmwACgkQoqBt8qM6 VPrcqwf/eNgmtNN/JAdZm/VdivCIcwuddNtxXNnjPhHigXkkfVHI5PwRF9gj8jHz buJgTaWRCGlNZYnXFpb2VcK+XHgCAnOlFDL9y6MJREpmB/8GpT2r20JQyRgMODJk Jwdvb08e0v+bpR98pUYuoa2Wt5cYSkmHTEL0JtA9ddYC76Rh3vkcgW3ZohNYx0AY CTepmSsTWIfZmOX32Uu4/0HLy9BQMTOMOfN7n+sodcamZctNR/arnMj/+kTZVZcM fBHQxvlSC1N1pfglRNn8bj7KoSg9ME6Ae/XRsW/g6ugj3QHAFZwyNeNbDl4dtt/t 150Bv6gx+LuzNSFPhuHk3R5wW6byKg== =WWIt -----END PGP SIGNATURE----- --=-=-=--