From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Baines Subject: Re: [PATCH 1/2] Support publishing build events Date: Sat, 16 Nov 2019 23:13:28 +0000 Message-ID: <874kz3ifdz.fsf@cbaines.net> References: <8736fjqbrd.fsf@cbaines.net> <20191028081026.25988-1-mail@cbaines.net> <87bltbts9h.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:39854) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iW7G6-0006np-U3 for guix-devel@gnu.org; Sat, 16 Nov 2019 18:13:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iW7G5-0005GZ-Oh for guix-devel@gnu.org; Sat, 16 Nov 2019 18:13:38 -0500 In-reply-to: <87bltbts9h.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi Chris, > > Christopher Baines skribis: > >> --- >> Makefile.am | 8 +- >> bin/cuirass-send-events.in | 90 +++++++++++++++++++++++ >> src/cuirass/base.scm | 9 ++- >> src/cuirass/database.scm | 142 +++++++++++++++++++++++++++++++++--- >> src/cuirass/http.scm | 24 ++++++ >> src/cuirass/send-events.scm | 69 ++++++++++++++++++ >> src/schema.sql | 12 +++ >> src/sql/upgrade-5.sql | 15 ++++ >> 8 files changed, 356 insertions(+), 13 deletions(-) >> create mode 100644 bin/cuirass-send-events.in >> create mode 100644 src/cuirass/send-events.scm >> create mode 100644 src/sql/upgrade-5.sql > > Sorry for the delay. It LGTM, thank you! > > Please add a commit log :-), and let us know when you=E2=80=99d like to t= est > with the instance on berlin or that on bayfront. Great :) I have access to bayfront already, so I think that's the place to try this out initially. > IIUC, the =E2=80=98send-events=E2=80=99 program is provided as a debuggin= g aid, right? > I mean it=E2=80=99s not used anywhere in the code. Well, it would be potentially better to send the events from the same Cuirass process that manages the builds, as then the events could be sent out immediately. However, I don't really know how fibers work, so I went with a separate process to make it easier to manually test, and to reduce any risk of interfering with other Cuirass functions. > If you can think of ways to tests parts of this, that=E2=80=99d also be g= reat, > but it shouldn=E2=80=99t block it. Ok. I'll hopefully have some time in the next week or two to take another look. I'll add change logs to the commits, do some more manual testing, and have a look at writing some automated tests. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl3QgphfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XeqZhAAivaVc43t7JSg1Bne+OYzQHvb/mEmSMIAg9sgyfrBt/1zoc9HwC+Lw/wJ 7L+7WBexVZVXAPvqccB73rDz5fRMvhtXRynmA6K2mJp9/MxWugtx8oXPLBz99adi bpVxP8nbHQ9bXis8HOh7c7QuVxRMTeQQ4ZjQ3puGzfEanh2jYh/StJAY79IFOcwz Pdpxn7Pb0CyudsbRkgXZU5iDoaB0hCORcIccQUmPGhGGwVYUDj6KJy1gDBo6QQPf tGNO6u4Nq8XN1pdVBmK4RawixsQlmGK8zYMy8fUKd9r1KgOazSTyyyu7gboxdt+o O+6/8cr3AEERVzJQY5F1uYl0xzd+U7tL07FeDgYBztJ1ltPLfBLgEccR6YrDQu61 Jk9jQp/1c72/gavTO5nVNStmHXcl98qO810cydVny2GhDxUBCwMUFgBW5XvVCBWf Tcp4tL5OLguDZBhsDQeV/FSg6UAhOobORGg69wPHjb+LMa3xKroj80xcmVsv+h0n sRHMRoWda7TyKnmmnh9gyJyD42dtc9FK2y8dTMo0Nl/yOecS31yxtyeXFSiTW9xY sHd60yznBz74H6zMFEKV982s+CUeOBQSE8tBe9BAQuCHjEZv/4tYPDMAb0tbVyC2 LYgiMYtvKyM04lGpmdztw+I4wQGlgIklMKH9hikdnthIUz+25lY= =CKMx -----END PGP SIGNATURE----- --=-=-=--