From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Nieuwenhuizen <janneke@gnu.org>
Subject: Re: 04/05: gnu: autoconf: Support cross-build.
Date: Thu, 23 Apr 2020 07:45:12 +0200
Message-ID: <874ktaoivr.fsf@gnu.org>
References: <20200419090521.13083.63849@vcs0.savannah.gnu.org>
 <20200419090523.C255A2049B@vcs0.savannah.gnu.org>
 <87tv1cx1yo.fsf@gnu.org> <87r1wg908o.fsf@gnu.org>
 <87lfmnqlrc.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:48906)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <janneke@gnu.org>) id 1jRUfp-0007yH-Fu
 for guix-devel@gnu.org; Thu, 23 Apr 2020 01:45:23 -0400
In-Reply-To: <87lfmnqlrc.fsf@gnu.org> ("Ludovic
 \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
 \=\?utf-8\?Q\?s\?\= message of "Wed, 22 Apr 2020 23:00:07 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org
Sender: "Guix-devel"
 <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

Ludovic Court=C3=A8s writes:

Hi!

>> Tests are disabled currently (even on master!), so I guess that
>> inserting this line break is fine :-)
>
> Damn it, this is terrible!  But not your fault, for sure.  :-)

Yes, it would be good to re-enable them during the next cycle.
>> -    (arguments `(#:tests? #f))
>> +    (arguments
>> +     `(#:tests? #f
>
> I=E2=80=99m really nitpicking, but could you move the XXX comment right a=
fter
> #:tests? #f?

As checkn on IRC: yes, right after "(arguments `(" right before #:tests

>> +                           (out  (assoc-ref outputs "out"))
>> +                           (store-directory (%store-directory)))
>> +                      (substitute* (find-files (string-append out "/bin=
"))
>> +                        (((string-append store-directory "/[^/]*-m4-[^/=
]*")) m4)
>> +                        (((string-append store-directory "/[^/]*-perl-[=
^/]*"))
>> +                         perl))
>
> I=E2=80=99m very much in favor of keeping regexps literal.  What about wr=
iting
> them as:
>
>   (substitute* =E2=80=A6
>     (("/[[:graph:]]/bin/m4")
>      (string-append m4 "/bin/m4"))
>     =E2=80=A6)

After discussing various options on IRC: keeping the parenthetical
(((string-append stor-directory...; we are using than for git and
perl, see https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D40698#16

> Also please move the comment right below =E2=80=98lambda*=E2=80=99.  :-)

Done!

> And then I think you can push it to =E2=80=98core-updates=E2=80=99.

Pushed to core-updates, together with a simalar patch for automake,
and a trivial one for texinfo.

Thanks!
janneke

--=20
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com