From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iToCACB7WmARNAAA0tVLHw (envelope-from ) for ; Tue, 23 Mar 2021 23:34:55 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id uMLQNh97WmDTIAAA1q6Kng (envelope-from ) for ; Tue, 23 Mar 2021 23:34:55 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A99B91068F for ; Wed, 24 Mar 2021 00:34:55 +0100 (CET) Received: from localhost ([::1]:60712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lOqY2-0001ql-PI for larch@yhetil.org; Tue, 23 Mar 2021 19:34:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44060) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOqXj-0001mo-59 for guix-devel@gnu.org; Tue, 23 Mar 2021 19:34:35 -0400 Received: from world.peace.net ([64.112.178.59]:51004) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOqXh-0006YA-5f; Tue, 23 Mar 2021 19:34:34 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOqXd-0007Sv-DJ; Tue, 23 Mar 2021 19:34:29 -0400 From: Mark H Weaver To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: imagemagick@6.9.11-48 to graft or not to graft with 6.9.12-2 In-Reply-To: <87ft0mhsjl.fsf@gnu.org> References: <87v99iki3l.fsf@netris.org> <87ft0mhsjl.fsf@gnu.org> Date: Tue, 23 Mar 2021 19:32:47 -0400 Message-ID: <874kh1jvid.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=64.112.178.59; envelope-from=mhw@netris.org; helo=world.peace.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616542495; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=RyEJl8urTTE+G8kAskd7IACnhttouUVc8EkVPgz3OVM=; b=BrC+01K22Qbod7jS1pbvOPLSUMdZn+P8VTNIDCG9tJGvvfw9x67NWALZJ/vxI6UH0vjwPK wab5Ct/kiqA7FHA6wRfVdLH2gMVvhQM9VfeeDrZzCLCLARlqpFeJ9ycn8K81ptihdH2HjA xIg2nO69ou1khPKoPyT30rqXdintzbn8fgj1UuQoVWGzl1pIn9uon0Lkc7uyF6M2z+Kn3p 3o7BT9QRz5d+9LEjZDIrrr0I7OSI8c9EjekhfNXvbgsUOMwW3qwa/A3s1GZwM/Yliz+r4q DRGdyba5lsILBi25K5xpfrhJj6z2sQV6jnxgJ16skNw9Mi3FWt+iWxEwV2E5DQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616542495; a=rsa-sha256; cv=none; b=OCnOOOf7MuOl0ZjRGoji6J2tHU/GnZSgYPCzbI3yL6sRbD/kNB2m5weijt1oqB2kbQz08/ qYIJ99jMrgdZzeDHulHk4H4Q1K9FOpiyXk3x91BLWEWGBmphdW6OVfcY5EzE95LBF6kLac aIrSZCa45munVh+XSILh9DCYMzTTIffEklOLrIulVPVOD3d+/z0hVwmYFjjkLUvJhxmn6K ZljcnGhGOP+Z6z5Udm45G/rrhTrWk2Mb5tEjW5KRY4/mnHaRuFawpUrf2B1Petk/rkor14 aZVzsS5+l5SnTd7QBeuVqLHO6yMMmEuLqJyW4zCFUMtJdB3rjJqvOYkJcZwELA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -2.42 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: A99B91068F X-Spam-Score: -2.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: HQnSHwRV3Z5u Hi Ludovic, Ludovic Court=C3=A8s writes: > Mark H Weaver skribis: > >> Andreas Enge writes: >>> And please let us agree that in the future, we only backport fixes in g= rafts >>> and do not update version numbers. >> >> I agree that in this particular case, that's what should have been done, >> and that we should still try to do it. It will be several days at least >> before I'm able to look at it, though. Would someone else like to try? >> >> I also agree that in general, we should be more careful to check for ABI >> compatibility before grafting. > > More specifically, for libraries, we should only ever use replacements > that are ABI-compatible. (That usually means that the major and minor > version numbers are the same, which may be what Andreas had in mind.) > Anything else is most likely broken. > > For command-line tools, I think we should only graft with replacements > that are backward-compatible at the CLI level. That requires manual > review of the changes, I guess. I wholeheartedly agree. Thanks, Mark