From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6ARmKrg9TGJsDwAAgWs5BA (envelope-from ) for ; Tue, 05 Apr 2022 15:01:44 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id EOFuJ7g9TGJiNgAA9RJhRA (envelope-from ) for ; Tue, 05 Apr 2022 15:01:44 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3264E2868F for ; Tue, 5 Apr 2022 15:01:44 +0200 (CEST) Received: from localhost ([::1]:50616 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nbioY-0006DU-R1 for larch@yhetil.org; Tue, 05 Apr 2022 09:01:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbinu-0006Aq-SA for guix-patches@gnu.org; Tue, 05 Apr 2022 09:01:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60178) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nbinu-0003A3-K1 for guix-patches@gnu.org; Tue, 05 Apr 2022 09:01:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nbinu-0003zN-G0 for guix-patches@gnu.org; Tue, 05 Apr 2022 09:01:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#53751] 06/07: gnu: git: Update to 2.35.1. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 05 Apr 2022 13:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53751 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: guix-devel@gnu.org, 53751@debbugs.gnu.org Received: via spool by 53751-submit@debbugs.gnu.org id=B53751.164916362115260 (code B ref 53751); Tue, 05 Apr 2022 13:01:02 +0000 Received: (at 53751) by debbugs.gnu.org; 5 Apr 2022 13:00:21 +0000 Received: from localhost ([127.0.0.1]:54075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nbinE-0003y4-RS for submit@debbugs.gnu.org; Tue, 05 Apr 2022 09:00:21 -0400 Received: from mail-qt1-f169.google.com ([209.85.160.169]:44735) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nbinB-0003xh-GQ for 53751@debbugs.gnu.org; Tue, 05 Apr 2022 09:00:19 -0400 Received: by mail-qt1-f169.google.com with SMTP id 10so10780864qtz.11 for <53751@debbugs.gnu.org>; Tue, 05 Apr 2022 06:00:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=UgSg0bwVrQZxF7H6tq0OvHhZdZWm7R3Szh3r4ZBepfw=; b=qkCVvDR5bEX8hpjFFWnA9FsQOpvCjJZsGe2bv6asCTcVMQPUzLQiGi/IXbGnOZ6xX0 nokvvqGX4ndfM22XKcBcAY8aJwb4e6h0bLpmYn21P+IZ/YZNYZQICrfYfFT4+4DRhoGp FJBQy1MZaoaYfoAVECckwrSCFP+7WEOXCu7qUcetsn0SODH28fTxnEFckqPfB80RpRzu q5Thw+CNt7a1MNSztfyNfE6hNbNNA5zyD6wIBi7NPR9TPcvvFD18UFuIo5yILwTmfwYd s188+pGUNXEXBzQJPsXSUweOuhKDEjMGSLGd5yfkwLLe1tzXde2+d6aWunNaZKDLcccx ROVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=UgSg0bwVrQZxF7H6tq0OvHhZdZWm7R3Szh3r4ZBepfw=; b=mb1U7WQ2N4h//yrs26TUK7QvItHp5kX+HgqFz8t8Z6wo+MJHrSB2byKKUV/gegs0Bq ifumaY0Zz/Uvo1pOT25Pif690iJXSOyplRaQAUr57RjvVgOroEcroCF2QpwWATedsoyn /Oazh/dgaQTFwrfjUyiDShhOk3Xj2/m2jCqX6v82IJxTHbheeFLQtcV8MPQCRIh7QJX8 +ttecF1cQmVotWUhCmwi+qtj843kc//V+hJjcl0/mWbRTpNai6clDkClP8Sy2Ba+rkz1 9gImN+N9OBoM6EkjhwwrnZLQCRGNaNsikjdwhatWF6UQFLzvu+sFl4MJWvgCi5VmhZls QnMA== X-Gm-Message-State: AOAM531c9XTOKONox0rOYyeQH5f2GUrZ4ME7Nsi9Nozax62KAw0Aqojs LHewOcddPBnoIw3ucx8ZBflAe4w38RI= X-Google-Smtp-Source: ABdhPJw3xG99jK7hOVLMMLMK00wFYZD+MTCZxhZeMUdRGqGVba01UU0FVj3AtYHYMlt+qN5LI1kKrQ== X-Received: by 2002:ac8:7c45:0:b0:2e2:293a:7966 with SMTP id o5-20020ac87c45000000b002e2293a7966mr2773582qtv.478.1649163608444; Tue, 05 Apr 2022 06:00:08 -0700 (PDT) Received: from hurd (dsl-10-136-94.b2b2c.ca. [72.10.136.94]) by smtp.gmail.com with ESMTPSA id e7-20020ac85987000000b002e1b7fa2201sm10741576qte.56.2022.04.05.06.00.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Apr 2022 06:00:07 -0700 (PDT) From: Maxim Cournoyer References: <164904612874.946.17349166055621457713@vcs2.savannah.gnu.org> <20220404042210.082F1C01684@vcs2.savannah.gnu.org> <87zgkzop06.fsf@cbaines.net> Date: Tue, 05 Apr 2022 09:00:05 -0400 In-Reply-To: <87zgkzop06.fsf@cbaines.net> (Christopher Baines's message of "Tue, 05 Apr 2022 10:23:38 +0100") Message-ID: <874k37znvu.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1649163704; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=UgSg0bwVrQZxF7H6tq0OvHhZdZWm7R3Szh3r4ZBepfw=; b=OlRCagyvESBjZ/xbarHjnVayL6cRlr5eDOkAZ568Ory2fCQiNv3RRGaLKuGiqiA0c6w1d7 jhNbZq8OovT8nWte6xeoPEI0g86psssyKyAp+omU/9mqYsoZ2V7y7WvJIy5PSbGm7fbNK0 R4WBwKZeZxOriK81ElS1ospCoNxVzejDIeh5FNhsIjzS88/eDTeBElYxx3zvkLlbVJQ31s 1xXGKXppQ1JO66G28bat7HlNOrt1ziNKdyPoFUehxhf35ZrpkMrxDWcGdwIBIStoLmqI82 eInqMCBRg05GgqL/ococP/w/U1/EQpGzZBa9MFGh4c2kGriRvTMg2RONxm0+YA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1649163704; a=rsa-sha256; cv=none; b=JVQTY9slv8jS9YYdr05GdsOJmkCQuPn6Aw9jnHJXub3sqesDUF2U+Qr5woaLloAVSRo8lz 8WlGkePdZG0wRX3+qI2r/Ygn0ynuICqhWJqjUMZcWusjV5vhDEwNPWspwSthL5EZdaUaHf l68CmmRLwQLrSxemrXo0f5o4Vev5xEupcobaDhRwPnXzUa5gmbkHdMecZk/Redg1FhXnMD URI9hHtYLkppsDQUiDqhicXwXbNzSGHQ443jEos0HlGAJvuuPRI6gO3IbRmZeU7ckbApkH zs+EPrWpc5lOtVH2jfbB48uZk5w9FAL0ezZTPDQsO9wsXBuCaEHn3rLvw5JyHQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=qkCVvDR5; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.13 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=qkCVvDR5; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3264E2868F X-Spam-Score: 5.13 X-Migadu-Scanner: scn0.migadu.com X-TUID: G5UPlSLzI4NK Hi Christopher, Christopher Baines writes: > guix-commits@gnu.org writes: > >> apteryx pushed a commit to branch master >> in repository guix. >> >> commit 223a3d7f7fdb6af9c4c090785cab15d38680e887 >> Author: Maxim Cournoyer >> AuthorDate: Mon Apr 4 00:06:48 2022 -0400 >> >> gnu: git: Update to 2.35.1. >> >> * gnu/packages/version-control.scm (git): Update to 2.35.1. >> [phases]: Delete trailing #t. >> >> Signed-off-by: Maxim Cournoyer >> Modified-by: Maxim Cournoyer > > I've been looking in to this commit, since I noticed a large number of > rebuilds. > > It looks connected to Greg's patch submitted in Issue #53751, but rather > than being authored by Greg, it's authored by Maxim. Hm, indeed, the author field should have been Greg Hogan; not sure what happened there (I applied it with 'git am -3' as usual); hence my sign-off in the commit message metadata. I'll pay more attention to these in the future. > Additionally, I'm guessing that the changes in Greg's patch are much > less impactful in terms of rebuilds compared to this commit, which also > removes the trailing #t from the phases, which will have affected every > variant of the git package, including variants like git-minimal/fixed, > which as the commit in the code says, is intended to rarely change. Greg had marked it for the staging branch, but my summary verification led me to believe only 347 packages would be impacted for (which I remember finding a bit surprising): --8<---------------cut here---------------start------------->8--- $ guix refresh --list-dependent git Building the following 186 packages would ensure 347 dependent packages are rebuilt: debops@1.1.0 git-repo@2.4.1 simavr@1.7 libjcat@0.1.9 [...] --8<---------------cut here---------------end--------------->8--- and --8<---------------cut here---------------start------------->8--- $ guix refresh --list-dependent git-minimal Building the following 69 packages would ensure 213 dependent packages are rebuilt: pplacer@1.1.alpha19 bap@2.0.0 [...] --8<---------------cut here---------------end--------------->8--- But I missed the git-minimal/fixed variant. I should have tried the 'guix build libreoffice' test! > I'm all for making changes fast, but I'm not sure the removal of #t from > the phases in thisq package definition is worth the cost of the > thousands of package rebuilds on the master branch. Yeah, I don't think it's worth it. Reverted it for now, and applied the original version that didn't touch the trailing #t: --8<---------------cut here---------------start------------->8--- 78e8c20179 origin/master gnu: git: Update to 2.35.1. 8a9bf794e1 Revert "gnu: git: Update to 2.35.1." --8<---------------cut here---------------end--------------->8--- Thanks for the report, and sorry for the mess :-) Maxim