From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 0NyGA8vFxmMlTgEAbAwnHQ (envelope-from ) for ; Tue, 17 Jan 2023 16:59:07 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id UBZzA8vFxmOHcAEAauVa8A (envelope-from ) for ; Tue, 17 Jan 2023 16:59:07 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C3AF32801A for ; Tue, 17 Jan 2023 16:59:06 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHoM7-0001Gu-9E; Tue, 17 Jan 2023 10:58:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHoM5-0001Gd-QC for guix-devel@gnu.org; Tue, 17 Jan 2023 10:58:33 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHoM4-0001QG-Pu; Tue, 17 Jan 2023 10:58:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=tlNjTshcwR4qN2L/DZQn/b46WOqv62IfyHpbIL9OWFs=; b=SJbnzxNFjs7i2yffJ+a9 XgC/Qac+2NMZFxXfyQ2UKxJc7mIEyByA8UMplfWpp1fATB/k1H9qxJlBO6S9RLIooDAn79Cv6ugOm x/0fO0GbWcOWaSfmX57Tr4Hr9YhefQYGG4rMQlUbEp+6k6k3s4svuU+Zccvhqmh6k3vLbI5ZBzleu lHapzw7ZJa92J6JSssPjmzJ6YUaOcL9/wlp4it0zJ+dzLriZTorADDSMuR54eZz+ijs8SBWC1+i5M CIyiuTc26+KQzh4Xhc65UJbXQD2+IRIDFkVfkL/BG++wnTOXa85VrZZXBTW28VktpWS9BA+ADZ6la qgTKWNCK1V46Hg==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHoM4-0000Xn-2c; Tue, 17 Jan 2023 10:58:32 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Bruno Victal Cc: guix-devel Subject: Re: Improving how NGINX modules are used and built References: <87pmborneu.fsf@gnu.org> <0cbc38f9-6b50-9653-7a67-4e0b16ca3e06@makinata.eu> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Octidi 28 =?utf-8?Q?Niv=C3=B4se?= an 231 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du Zinc X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 17 Jan 2023 16:58:30 +0100 In-Reply-To: <0cbc38f9-6b50-9653-7a67-4e0b16ca3e06@makinata.eu> (Bruno Victal's message of "Wed, 11 Jan 2023 11:58:36 +0000") Message-ID: <874jspf909.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=SJbnzxNF; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673971146; a=rsa-sha256; cv=none; b=T5rPnZ67z8of1WrlA5fQBV+sEYsaDeBMlwHAXu6Bli8s9YsMti6LQHG34LZZVHloScO1yf qqZFYogFkk5CD5yFTc03QR9UFwMK5bL5prtqvb3HfMX6KLYlbGpDlN4GWsjgimU/bV5bB1 l3+QspC6LhVKcPFckydbIM7/INDx3iI1tzfm8JLjeWEffV2VAoH5XfDXuquy7V/SeuhFCG wDPP9RUkZIbSvfMwfnOyDKKgIm/IZ2hxNNrWhhYYn9W7mgXxn4hvcOkZfvpltjWewKvuZt a+6vrOmW7HnAqQ5UgSr270AJRjhZRZPrrnJfwzr0Z5pPXr7Me3tJf52DP/SfAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673971146; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=tlNjTshcwR4qN2L/DZQn/b46WOqv62IfyHpbIL9OWFs=; b=cQLJlZ8A6nKwQQDoVKqFkGohCCb1eeThtJxGFxdO6CY+D+PT8an94hArRXb4bO0X6LmNvx cx4PZGEDNFSdZ3b/C0ANM3XMCVmj4lX/3gkad8HNTxyI1nAoxCmOxH9A9WxzNjJRf1LwMp WbLCPHfo4nsp+PHW45Ai2nU1e5RkctIG5yFzETiY+sFbGEMmm7gu27W3GvYPy2SUodZBpm XX5eatf+bjtGZRB0S9m/0N0NN+zt4tMcLpf4TMuYxEKHb8uS2PWBzW97tBtszxDqfoC7dD 796t0Yi6WGZb89NpUbrzjwYRp1I+O/gtiHWhzYOKDh4pZUqw/eLFkZjeX0YRTA== Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=SJbnzxNF; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-Migadu-Spam-Score: -7.59 X-Spam-Score: -7.59 X-Migadu-Queue-Id: C3AF32801A X-Migadu-Scanner: scn1.migadu.com X-TUID: lErK4L1KOg9R Hi, Bruno Victal skribis: > On 2023-01-09 10:51, Ludovic Court=C3=A8s wrote: >> Hello! >>=20 >> mirai skribis: >>=20 >>> An oddity of how nginx modules are packaged in guix is that they all pl= ace >>> the .so file under /etc/nginx/modules which is an odd directory to plac= e library object files. >>=20 >> To me that should be treated as a bug. Those .so files should go to >> $PKG/lib/nginx instead, or something similar. > > Fixing this bug is likely to cause pain to existing module users, as the = path to these .so > files is explicitly passed to and is what's documen= ted in the Guix manual. Right. We could imagine a transition period during which nginx module packages make their .so available under $PKG/lib/nginx primarily, but keep $PKG/etc as a symlink to that. [...] >>> And nginx-configuration should serialize the modules field as a series = of lines including >>> the module .conf files, that is: >>> >>> include "/gnu/store/......nginx-foo-module/etc/nginx/modules/ngx_foo_mo= dule.conf"; >>> include "/gnu/store/......nginx-bar-module/etc/nginx/modules/ngx_bar_mo= dule.conf"; >>> ... >>> >>> (note: a directory union could be used here as an alternative) >>=20 >> I=E2=80=99d say that ideally, one could extend with >> modules, and that would automatically create the =E2=80=98load_module=E2= =80=99 >> statements. [...] > I'm not convinced that should be generating load_mo= dule statements here, > these should be generated by the module-package itself into a .conf file = and > generates a include statement for it. Reason being that nothing stops a m= odule being comprised > of several .so files or be a "pseudo-module", that is, it's a .conf snipp= et to be included. Yes, that sounds even better. From the admin=E2=80=99s viewpoint, it=E2=80= =99s kind of the same anyway: you list a bunch of packages to use as nginx modules, and it =E2=80=9Cjust works=E2=80=9D, with the appropriate =E2=80=98load_mod= ule=E2=80=99 ending up directly or indirectly in the nginx config file. Thanks, Ludo=E2=80=99.