From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id mGsYDPuzCmRivwAASxT56A (envelope-from ) for ; Fri, 10 Mar 2023 05:37:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id wGx3C/uzCmRtXAEAG6o9tA (envelope-from ) for ; Fri, 10 Mar 2023 05:37:15 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AA3551F5D for ; Fri, 10 Mar 2023 05:37:14 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=EfQgSZSX; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1678423035; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=pfudZ9/5sWdVXb3fwj0bs7kGS2NjWlgp2ascV0LFvQQ=; b=f73neiN5902EJ+jpIv8Rk1khVzJ0ZrujhG2sRc2zJb4DIejRCNPPbpaORvnJklSXvNw4k8 Rx2B3xfV3IGSJ8MpSYMCEWl8l7eKqlqNEbs4vgw2sxVu3WzaZtCWaefewP4DVvEF9Q8Hrp JQFhe+jotaMz2QxiFel8xjP7X1Sls29WCoHEgIvVGWjGJbJ39/mJI5T//UY8/qFkab3lYu UGLgvtlgO5smu1+e1mSMtiT+IGPMTRsroWTOjxL/Z/2dvXUwYThdjZdIBL2UsfsegLAtFA i5vsMfEM/ig9DN1mW6xyg0gwlQ2MEWk+sTIFfBllfSmYrS8GziHz40Cv8216jw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1678423035; a=rsa-sha256; cv=none; b=mLqY7kpMgXYehJfYdURpsxSyB8TX9FykrzF06/GrGlOumUC6XEvtM27/CDwN7HOGqp2dIZ W61oJHA6bvvwyE6RIPjBRYPCv+W/F1WRfv47ph/irTuPBtVpOo9GBsfQUgs9ht/5BA+Mb3 st7O+GrnHde9PM6Y5bBM41Hem7L9mkYwzdjPY6HHaYV+7MImhU75mfUgeReR1b7tfh85GF LcoXz693B9yXCswnly8Y+zCN0sXjba6VXcDZhkMy7KKvwKoDKAJ4NQ73QSfeIbhH3Z9vs3 gUxk4NaW0U6+OA+4ovTGLsgGhnuqcw+ydJ2kaM7CdfMiDPBlHMVnQXaLc+At9w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=EfQgSZSX; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1paUUq-0005Ix-Ow; Thu, 09 Mar 2023 23:36:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paUUo-0005Ia-QW for guix-devel@gnu.org; Thu, 09 Mar 2023 23:36:46 -0500 Received: from mail-qv1-xf31.google.com ([2607:f8b0:4864:20::f31]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1paUUm-0000eJ-LL; Thu, 09 Mar 2023 23:36:46 -0500 Received: by mail-qv1-xf31.google.com with SMTP id y3so2953442qvn.4; Thu, 09 Mar 2023 20:36:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678423002; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=pfudZ9/5sWdVXb3fwj0bs7kGS2NjWlgp2ascV0LFvQQ=; b=EfQgSZSX8LU/s56T6HwWtfCsX0is5vyKj9OPMkjN3nIVrx0qZrkaGFtRPiLbAzftIe FVlkPnqDnWFvTB0B4pGX656Hd0PrF7QKtmOY72n6eKPhJaOpiEUUzzOmNje2Jlze4oLx jY8sS2LD3m16pK/Tntud9vFtXVtEpTJRh8ZiztQOaSxkD/+8PzcI9aHR57vxfGe38UMS ZeN3wXRHCc+6uoctDQYcOX1R7NI2imLEhSd4+8FbaQZ0eFLnrM10568lPBN2pnctxSTx z9w6gjnoufI58Te0o+Sbz9lwih+K5G4UrwVGj7yOSupHpspcchM/ub5uUwq4b1NuhdmS JG1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678423002; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pfudZ9/5sWdVXb3fwj0bs7kGS2NjWlgp2ascV0LFvQQ=; b=1lBGK9Vw/3/vnb8K21dlPDYiJq7J7KXSa5bSLRNqm6gWT/KxwW9JpcXocszMotEghu qBwtn3j+kuj4BwdL4ZgWgv3r++BEVc7h7ChMdCkvUbB9YbVsrwaSkKOpfeg7Yw5xUJTx mGHIRx3U3j1D+GSsdanNCk/oUQtCDz/ooHEGFGKfckdyz94U7Swk14ucAbzr2hDJ9//s 4EuLIRKwizIls2MhjAECLtyV0k/SbYoLUSZvcEbdVd1gGLOj5fSXBMuyDH4Epj69DEPf DZuqiAnzLIgVfSmGj6GGisQ7QQfEXMCTb6KmIioIJ7/ln87+UJw9sB+YpdRSo+PYxVvg sutQ== X-Gm-Message-State: AO0yUKUmjs1jwrg1F5XpEPcZ97XBQD+V/tZZgHvfojXHuHqcyuPWEsrM 2RRF7J/OSCJkfQ59vEMHKc3gakRuh+negh8z X-Google-Smtp-Source: AK7set950fNWis83dnOCeDkj2dDgTrfpQKYwyQRmlO5boV+4KWi4syVheK/vBDr6lz34g0fezlI1tg== X-Received: by 2002:a05:6214:1248:b0:56f:8b5:3e94 with SMTP id r8-20020a056214124800b0056f08b53e94mr1206818qvv.14.1678423002109; Thu, 09 Mar 2023 20:36:42 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1000]) by smtp.gmail.com with ESMTPSA id f4-20020a37d204000000b0073b967b9b35sm604410qkj.106.2023.03.09.20.36.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Mar 2023 20:36:41 -0800 (PST) From: Maxim Cournoyer To: Simon Tournier Cc: Andreas Enge , =?utf-8?B?5a6L5paH5q2m?= , Ludovic =?utf-8?Q?Court=C3=A8s?= , Christopher Baines , guix-devel@gnu.org, 61894@debbugs.gnu.org, guix-maintainers@gnu.org Subject: Re: bug#61894: [PATCH RFC] Team approval for patches References: <878rgga1qv.fsf@inria.fr> <871qm8wf8e.fsf@cbaines.net> <87r0u86qgo.fsf_-_@gnu.org> <87y1o9mina.fsf_-_@envs.net> <861qm0da4y.fsf@gmail.com> <87sfegwh28.fsf@gmail.com> <878rg7uqb4.fsf@gmail.com> <86lek6ntpb.fsf@gmail.com> Date: Thu, 09 Mar 2023 23:36:39 -0500 In-Reply-To: <86lek6ntpb.fsf@gmail.com> (Simon Tournier's message of "Thu, 09 Mar 2023 10:46:08 +0100") Message-ID: <874jqtte7c.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::f31; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qv1-xf31.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Scanner: scn0.migadu.com X-Migadu-Queue-Id: AA3551F5D X-Spam-Score: -9.93 X-Migadu-Spam-Score: -9.93 List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-TUID: oqB9BInxOuBN Hi Simon et al., Simon Tournier writes: > Hi Maxim, > > On Wed, 08 Mar 2023 at 12:05, Maxim Cournoyer = wrote: > >> On a side note, it would also introduce some kind of hierarchy in the >> group, which I dislike. One of the things that make Guix special is >> that it's pretty flat -- everybody can participate at the same level, at >> least between committers). I'd rather we don't try to emulate Debian on >> that point. > > Hierarchy already exists, as in any social group, as in any group of > people collaborating. The hierarchy is currently informal. > > And it is not really =E2=80=9Cpretty flat=E2=80=9D because some individua= ls from that > group have more (informal) power than other. That=E2=80=99s not necessar= y a bad > thing. :-) For instance, the access to the build farms is restricted, > the ability to restart Cuirass job is restricted, commit access is > restricted, money spending is restricted, etc. Apologies for starting a tangent (which is interesting in its own!). Rewinding to the beginning, I believe the novelty proposed in this patch is (quoting the original message): > With the proposed policy, members of a team would also have to review > and approve each other=E2=80=99s work. Formal approval means getting an > explicit =E2=80=9CLGTM=E2=80=9D (or similar) from at least one other team= member. In other words, to give teams the power to gate the changes touching their scope. That's reasonable, if we have functional teams. I'd argue we aren't there yet. And also: > I think it avoids the unavoidable misunderstandings that can arise in > a growing group and help pacify day-to-day collaboration. Again, "pacify" irks me a bit in this sentence, given I consider collaboration has and continues to be cordial in our community, unless I've been living under a rock. --=20 Thanks, Maxim