From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Simon Tournier <zimon.toutoune@gmail.com>
Cc: Andreas Enge <andreas@enge.fr>,
Felix Lechner <felix.lechner@lease-up.com>,
Leo Famulari <leo@famulari.name>,
guix-devel@gnu.org
Subject: Re: Commits and bug closing
Date: Wed, 12 Apr 2023 22:22:22 -0400 [thread overview]
Message-ID: <874jpkldwh.fsf@gmail.com> (raw)
In-Reply-To: <87mt3kkmvv.fsf@gmail.com> (Simon Tournier's message of "Fri, 07 Apr 2023 12:27:48 +0200")
Hi Simon,
Simon Tournier <zimon.toutoune@gmail.com> writes:
[...]
> Somehow, the current informal “convention” is to add,
>
> Fixes <https://issues.guix.gnu.org/12345>.
>
> in the commit message that closes specific bug. However, it is not
> fully uniform,
>
> gnu: openjdk10: Build from hg.
>
> * gnu/packages/java.scm (openjdk10)[source]: Use HG-DOWNLOAD.
>
> This fixes <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62071>
> for OpenJDK 10.
>
>
> or
>
> gnu: icecat: Fix Kerberos support.
>
> Fixes <https://bugs.gnu.org/48959>.
I'd say the more correct one is the later, assuming a GNU change log
followed, since the change log should appear after the descriptive
commit message, if any.
--
Thanks,
Maxim
prev parent reply other threads:[~2023-04-13 2:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 2:48 [core-updates] It would be nice to fix libsndfile CVE-2021-3246 (arbitrary code execution via crafted WAV file) Leo Famulari
2023-04-05 3:13 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2023-04-05 8:06 ` Josselin Poiret
2023-04-05 8:46 ` Andreas Enge
2023-04-05 15:54 ` Leo Famulari
2023-04-05 16:19 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2023-04-06 19:11 ` Commits and bug closing (was: something else) Andreas Enge
2023-04-07 10:27 ` Simon Tournier
2023-04-13 2:22 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jpkldwh.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=andreas@enge.fr \
--cc=felix.lechner@lease-up.com \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).