From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Synchronizing descriptions with GSRC? Date: Wed, 10 Jul 2013 22:52:14 +0200 Message-ID: <8738rm9lz5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36044) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ux1Rw-0007se-Qt for guix-devel@gnu.org; Wed, 10 Jul 2013 16:57:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ux1Ru-000264-CL for guix-devel@gnu.org; Wed, 10 Jul 2013 16:57:20 -0400 Received: from hera.aquilenet.fr ([141.255.128.1]:33218) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ux1Ru-00025x-5d for guix-devel@gnu.org; Wed, 10 Jul 2013 16:57:18 -0400 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: guix-devel@gnu.org Cc: Brandon Invergo --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello! After some refactoring, commit c4ca941 extends our structures to incorporate a =E2=80=98description= =E2=80=99 field whose value is taken from GSRC=E2=80=99s manifest [0]. If you apply this patch: --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/build-aux/sync-synopses.scm b/build-aux/sync-synopses.scm index c1049d3..7d64533 100644 --- a/build-aux/sync-synopses.scm +++ b/build-aux/sync-synopses.scm @@ -58,5 +58,15 @@ (format (guix-warning-port) "~a: ~a: proposed synopsis: ~s~%" (location->string loc) (package-name package) - upstream))))) + upstream))) + + (let ((upstream (gnu-package-doc-description descriptor)) + (downstream (package-description package)) + (loc (or (package-field-location package 'description) + (package-location package)))) + (when (and upstream (not (string=? upstream downstream))) + (format (guix-warning-port) + "~a: ~a: proposed description:~% ~a~%" + (location->string loc) (package-name package) + (fill-paragraph upstream 79 5)))))) gnus) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable then =E2=80=98make sync-synopses=E2=80=99 reports suggested descriptions (a= nd if you do it from Emacs with M-x compile, you can use C-x ` to jump to the location in Guix, and thus easily compare the descriptions.) After a quick glance over the differences, it=E2=80=99s not clear to me what should be done. Often, descriptions in GSRC are shorter that what we have. Sometimes they=E2=80=99re the same, or stripped version of those we = have. Sometimes they paraphrase those we have. Descriptions in Guix are typically taken from the upstream web page or README file, so I would intuitively feel like the upstream description better characterizes the package. I find some of the stripped descriptions better (Bison, for instance), while others look too terse to me (GMP, MPFR, and MPC, for instance). Perhaps we should have clearer criteria as for what to put in descriptions, to start with. Anyway, what do people think? Would someone like to compare all these and pick-and-choose? Thanks, Ludo=E2=80=99. [0] http://lists.gnu.org/archive/html/bug-guix/2013-04/msg00117.html --=-=-=--