From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikita Karetnikov Subject: Re: [PATCH] guix package: Add '--delete-generations'. Date: Tue, 24 Sep 2013 11:21:29 +0400 Message-ID: <8738ouu1l2.fsf@karetnikov.org> References: <87vc2o4qwc.fsf@gnu.org> <87y57kljro.fsf@karetnikov.org> <87hae81uvo.fsf@gnu.org> <87li2oslzh.fsf_-_@karetnikov.org> <878uyo60gp.fsf@gnu.org> <877ge7onje.fsf@karetnikov.org> <87eh8ftuii.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOMrg-0000C4-SW for guix-devel@gnu.org; Tue, 24 Sep 2013 03:16:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VOMrc-0002gb-5j for guix-devel@gnu.org; Tue, 24 Sep 2013 03:16:56 -0400 In-Reply-To: <87eh8ftuii.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Mon, 23 Sep 2013 17:41:57 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >>>> I had noticed that =E2=80=98--roll-back=E2=80=99 doesn=E2=80=99t outpu= t anything with >>>> =E2=80=98--dry-run=E2=80=99, so I implemented =E2=80=98--delete-genera= tions=E2=80=99 similarly. Maybe >>>> it would be better to print something. WDYT? >>> Agreed (in a separate patch.) I don=E2=80=99t think that I=E2=80=99ll have time for this before the relea= se. I=E2=80=99d like to be able to test the MIPS binaries. >>> =E2=80=9CDelete the generations matching @var{patterns} or ... when omi= tted.=E2=80=9D >>> Or what actually? I would expect it to delete all the generations but >>> the current one when PATTERN is omitted, right? OK. Should it delete the current generation when it=E2=80=99s specified explicitly, e.g., =E2=80=98--delete-generations=3D5=E2=80=99? What about o= ther patterns? >>>> +(define (link-to-empty-environment generation) >>>> + "Link GENERATION, a string, to the empty environment." >>> s/environment/profile/ maybe? (I know there are other inconsistencies >>> in these files.) OK. >>> Ideally this factorization would go in a patch of its own, before the >>> one that adds --delete-generations. Is that doable for you? >> I think so. Sorry, I=E2=80=99m not sure what have to be changed. (I=E2=80=99ve just lo= oked through the module.) Do you have time to work on this? >>>> + (define (apply-to-generations function profile pattern) >>> s/function/proc/ to follow the convention. OK. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBAgAGBQJSQT2BAAoJEM+IQzI9IQ3831gQAJAWDUSHCZW4iEesi8Ppj0bG s067bF60QA/C3B4KE2zMM6qv+bZC+v5BUEXGFcGSyhrewS2xVqA7N5FMmojn7AC5 3eYrAT+mc0dUZEG7zyTrD/gA1KGrVrKqKdu7WGCFLI4hfuT3BayFdb7Fz0/Ws94H ypTnYh/CCvh2hnDlfO4+xF24MMFIxFPS71G9BDrGpZ3H6sp59RVMMNPyeWsQtoXe w5132P7A44Wq8KIos8Qa1oFxrOh8hv/M9qp+FaXIWoBMJBvjX3icJ2Qe+uCpPg3r LfR5mvVqygXMJuPdwjsULaTbuvTrfjEi4H6uIJI5SrCUB1+mXlYp686u7fUOBLpl Vz+cXRAqKw9Ilo0rByPI1gdqg/M9bVJ0m4qSJcgrWVy57yQzEHXC5U1zSvjLRRBC GfxhjMOUx8yyBpugg97kNtqz9jrs6N+iYuHkJr7V7GSgRKu5FBm6BeLTZg5i6ULE b/dL6z8ycPdMZUcMcCItcr6WXSYbKvbopVudXB3Ruq6HHo1tKEzFASsgecV/GXOq o2AM6upk95qfeJ1vEFs8q0CCdoYIT5NP/+7mgPvoo4LKvA+pRa0Tq7zETsuO5C59 HH1HoJmDEKQOZKmroHTyQGwAU61LxPTxTwZ8HGnRydEzpGRmr+QcUUcVdQoNBx+0 FQvclm4+rEWgFxPH5m4Q =FWeZ -----END PGP SIGNATURE----- --=-=-=--