From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: Everything depends on openmpi
Date: Fri, 09 May 2014 23:09:23 +0200
Message-ID: <8738giwtfg.fsf@gnu.org>
References: <20140509061446.GA29644@debian> <87y4ybvz6i.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35884)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Wis2x-0005mi-7Q
	for guix-devel@gnu.org; Fri, 09 May 2014 17:09:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Wis2o-0007Ni-65
	for guix-devel@gnu.org; Fri, 09 May 2014 17:09:35 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:41952)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Wis2o-0007Ne-05
	for guix-devel@gnu.org; Fri, 09 May 2014 17:09:26 -0400
Received: from localhost (localhost [127.0.0.1])
	by hera.aquilenet.fr (Postfix) with ESMTP id 890E01358
	for <guix-devel@gnu.org>; Fri,  9 May 2014 23:09:24 +0200 (CEST)
Received: from hera.aquilenet.fr ([127.0.0.1])
	by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id KibvJVIBwW-T for <guix-devel@gnu.org>;
	Fri,  9 May 2014 23:09:24 +0200 (CEST)
Received: from pluto (reverse-83.fdn.fr [80.67.176.83])
	by hera.aquilenet.fr (Postfix) with ESMTPSA id 3DAFA7F8
	for <guix-devel@gnu.org>; Fri,  9 May 2014 23:09:24 +0200 (CEST)
In-Reply-To: <87y4ybvz6i.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Fri, 09 May 2014 15:50:29 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: guix-devel@gnu.org

Thanks Eric for addressing the issue.

Commit e5c66f8 does:

+(define-public fftw-openmpi
+  (package (inherit fftw)
+    (name "fftw-openmpi")
+    (inputs
+     `(("openmpi" ,openmpi)
+       ,@(package-inputs fftw)))
+    (arguments
+     (substitute-keyword-arguments (package-arguments fftw)
+       ((#:configure-flags cf)
+        `(cons "--enable-mpi" ,cf))))
+    (description
+     (string-append (package-description fftw)
+                    "  With OpenMPI parallelism support."))))

I don=E2=80=99t think I=E2=80=99ve mentioned it before, but we should refra=
in from using
=E2=80=98string-append=E2=80=99 in descriptions, because that prevents i18n=
 (xgettext
won=E2=80=99t catch it.)

Instead, I=E2=80=99d suggest leaving =E2=80=98description=E2=80=99 unchange=
d, and writing
=E2=80=98synposis=E2=80=99 in full, with =E2=80=9C(with MPI support)=E2=80=
=9D added at the end.
See =E2=80=98unionfs-fuse/static=E2=80=99 for an example.

Ludo=E2=80=99.