From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 3/3] gnu: Add mupdf Date: Mon, 15 Sep 2014 08:52:51 +0200 Message-ID: <8738btl6ik.fsf@gnu.org> References: <874mw95vi4.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34941) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTQ9k-0000kK-SD for guix-devel@gnu.org; Mon, 15 Sep 2014 02:53:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTQ9b-0002hC-QZ for guix-devel@gnu.org; Mon, 15 Sep 2014 02:53:00 -0400 Received: from hera.aquilenet.fr ([2a01:474::1]:42773) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTQ9b-0002h3-Jf for guix-devel@gnu.org; Mon, 15 Sep 2014 02:52:51 -0400 In-Reply-To: (=?utf-8?Q?=22Du=C5=A1an?= Xmetov"'s message of "Mon, 15 Sep 2014 07:20:35 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?utf-8?Q?Du=C5=A1an?= Xmetov Cc: guix-devel@gnu.org, Alex Kost Du=C5=A1an Xmetov skribis: > On 9/15/14, Alex Kost wrote: >> 5 * trailing space. >> > > They were generated by diff, won't removing them break the patch? I=E2=80=99m not sure, and that=E2=80=99s why I think it=E2=80=99s OK to kee= p trailing spaces in diffs (and because the tools generate them this way.) >> >>> + (inputs >>> + `(("curl" ,curl) >>> + ("freetype", freetype) >> >> ("freetype" ,freetype) >> > > Yup. > >> >>> + (synopsis "A lightweight PDF viewer and toolkit.") >>> + (description >>> + "MuPDF is a C library that implements a PDF and XPS parsing and >>> rendering >>> +engine. It is used primarily to render pages into bitmaps, but also >>> provides >>> +support for other operations such as searching and listing the table of >>> +contents and hyperlinks. >>> + >>> +The library ships with a rudimentary X11 viewer, and a set of command >>> line tools >>> +for batch rendering (pdfdraw), examining the file structure (pdfshow), >>> and >>> +rewriting files (pdfclean).") >>> + (license license:agpl3+))) >> >> I think people usually avoid a period in a synopsis and use a double >> space after a period in a description. Also the description should be >> wrapped by 72 (or 78?) characters in a line. Indeed. Actually =E2=80=98guix lint mupdf=E2=80=99 would tell you that the= synopsis shouldn=E2=80=99t start with =E2=80=9CA=E2=80=9D and shouldn=E2=80=99t end = with a period. Thanks in advance! Ludo=E2=80=99.