From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add samtools
Date: Mon, 15 Dec 2014 23:12:59 +0100
Message-ID: <87388gftp0.fsf@gnu.org>
References: <idj61dikz76.fsf@bimsb-sys02.mdc-berlin.net>
	<878uie6pd9.fsf@gnu.org> <idj4mt1kxkm.fsf@bimsb-sys02.mdc-berlin.net>
	<87k31wysbs.fsf@netris.org> <87y4qcj728.fsf@mango.localdomain>
	<8761dfmtq5.fsf@gnu.org> <87a92rse9s.fsf@netris.org>
	<87zjarqy5n.fsf@netris.org>
	<idjvbldjgb9.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52016)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Y0dt5-0007Jg-83
	for guix-devel@gnu.org; Mon, 15 Dec 2014 17:13:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Y0dsz-0006Ym-LI
	for guix-devel@gnu.org; Mon, 15 Dec 2014 17:13:07 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:49185)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Y0dsz-0006Yf-EN
	for guix-devel@gnu.org; Mon, 15 Dec 2014 17:13:01 -0500
In-Reply-To: <idjvbldjgb9.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's
	message of "Mon, 15 Dec 2014 12:36:10 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

>>>>> Can we disable the test suite for certain architectures?  Or would th=
ey
>>>>> have to be disabled completely?
>>>
>>> Since it fails the same way on mips64el, I suggest this instead:
>>>
>>>    #:tests? (string=3D? (or (%current-system) (%current-target-system))
>>>                           "x86_64-linux")
>>
>> Oops, we forgot to mention that there should be a comma before that
>> first open paren, like this:
>>
>>     #:tests? ,(string=3D? (or (%current-system) (%current-target-system))
>>                             "x86_64-linux")
>
> Attached is a patch that disables the tests on all systems but
> x86_64-linux.  I'm unsure about the indentation, though.  Should the
> compared string really be aligned with the arguments of `(or' (as shown
> above), or rather aligned with `(or', the argument to `(string=3D?' (as in
> the attached patch)?

The patch uses the right alignment.

When in doubt, you can check =E2=80=9CFormatting Code=E2=80=9D in =E2=80=98=
HACKING=E2=80=99 (although I
admit the style guidelines it refers to is quite verbose.)

> From c9846248c28f2c22660c156d4275326fe8afac80 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Mon, 15 Dec 2014 12:23:01 +0100
> Subject: [PATCH] gnu: samtools: disable tests for non-64-bit systems
>
> * gnu/packages/bioinformatics.scm (samtools): disable tests for all non-6=
4-bit
>   systems because of an upstream bug in the test data.

Applied, thanks!

Ludo=E2=80=99.