From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Add 'waf-build-system'.
Date: Sun, 01 Feb 2015 22:08:37 +0100
Message-ID: <87386pfiga.fsf@gnu.org>
References: <87pp9yvap6.fsf@mango.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57553)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YI3z8-0006Th-1f
	for guix-devel@gnu.org; Sun, 01 Feb 2015 18:31:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YI3z6-00063l-I1
	for guix-devel@gnu.org; Sun, 01 Feb 2015 18:31:21 -0500
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54012)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YI3z6-00063h-Fx
	for guix-devel@gnu.org; Sun, 01 Feb 2015 18:31:20 -0500
In-Reply-To: <87pp9yvap6.fsf@mango.localdomain> (Ricardo Wurmus's message of
	"Wed, 28 Jan 2015 22:48:05 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org

Ricardo Wurmus <rekado@elephly.net> skribis:

> attached is a patch to add the waf build system.  Although waf is called
> a meta build system, most applications that I've encountered so far (all
> related to audio) have the standard build phases as the GNU build
> system.
>
> The waf build system is embarrassingly similar to the Python build
> system.  Essentially, the phases are run by executing
>
>     python waf $PHASE
>
> instead of
>
>     python setup.py $PHASE
>
> Unlike the Python build system, however, there is a configure phase, and
> not everything important happens during the install phase.

OK.  Did you find it more appropriate to extend =E2=80=98gnu-build-system=
=E2=80=99
rather than =E2=80=98python-build-system=E2=80=99?

> From adc52a74fb12943fd77c97bf75a2092e839f9024 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Wed, 28 Jan 2015 22:39:03 +0100
> Subject: [PATCH] Add 'waf-build-system'.
>
> * guix/build-system/waf.scm, guix/build/waf-build-system.scm: New files.
> * Makefile.am (MODULES): Add them.

Could you add a few lines to guix.texi, under =E2=80=9CBuild Systems=E2=80=
=9D?  Other
than that this looks good to me.

Thank you,
Ludo=E2=80=99.