From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/2] gnu: sdl: Allow dlopen for OpenGL.
Date: Sat, 21 Mar 2015 22:25:36 +0100
Message-ID: <87384y3uwf.fsf@gnu.org>
References: <1426924046-10364-1-git-send-email-iyzsong@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37977)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YZQyO-0003PD-Dk
	for guix-devel@gnu.org; Sat, 21 Mar 2015 17:30:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YZQyE-0002hC-2M
	for guix-devel@gnu.org; Sat, 21 Mar 2015 17:30:24 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53304)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YZQyD-0002gf-Vi
	for guix-devel@gnu.org; Sat, 21 Mar 2015 17:30:13 -0400
In-Reply-To: <1426924046-10364-1-git-send-email-iyzsong@gmail.com>
	(=?utf-8?B?IuWui+aWh+atpiIncw==?=
	message of "Sat, 21 Mar 2015 15:47:25 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Cc: guix-devel@gnu.org

=E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:

> Fixes a regression introduced in 666aa99.
> Reported by Felipe L=C3=B3pez and David Thompson.
>
> * gnu/packages/sdl.scm (sdl)[inputs]: Add glu.
>   [arguments]<#:configure-flags>: Replace '--disable-sdl-dlopen' with
>   '--disable-alsa-shared --disable-pulseaudio-shared --disable-x11-shared=
'.

[...]

> --- a/gnu/packages/sdl.scm
> +++ b/gnu/packages/sdl.scm
> @@ -60,8 +60,11 @@
>      (build-system gnu-build-system)
>      (arguments
>       '(;; Explicitly link against shared libraries instead of dlopening =
them.
> -       ;; For X11, ALSA, PulseAudio, etc.
> -       #:configure-flags '("--disable-sdl-dlopen")
> +       ;; For X11, ALSA, and PulseAudio.
> +       ;; OpenGL library is still dlopened at runtime.
> +       #:configure-flags '("--disable-alsa-shared"
> +                           "--disable-pulseaudio-shared"
> +                           "--disable-x11-shared")

So without these flags libpulse.so, libalsa.so, etc. are dlopened?
(=E2=80=9Cdisable shared=E2=80=9D is a bit misleading in the flag names.)

>      (native-inputs `(("pkg-config" ,pkg-config)))
>      (inputs `(("libxrandr" ,libxrandr)
>                ("mesa" ,mesa)
> +              ("glu" ,glu)

Because of --disable-x11-shared, glu must be found at configure time,
right?

Thanks,
Ludo=E2=80=99.