From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Thompson Subject: Re: [PATCH] gnu: Add xxhash. Date: Tue, 28 Apr 2015 11:36:29 -0400 Message-ID: <87383k6z9e.fsf@fsf.org> References: <87oama8skj.fsf@fsf.org> <20150428144826.GB4503@debian> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yn7Yp-0003GU-ND for guix-devel@gnu.org; Tue, 28 Apr 2015 11:36:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yn7Yl-0007Hd-Bz for guix-devel@gnu.org; Tue, 28 Apr 2015 11:36:35 -0400 Received: from mail.fsf.org ([208.118.235.13]:39289) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yn7Yl-0007HO-4x for guix-devel@gnu.org; Tue, 28 Apr 2015 11:36:31 -0400 In-Reply-To: <20150428144826.GB4503@debian> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge Cc: guix-devel@gnu.org Andreas Enge writes: > On Sun, Apr 26, 2015 at 05:53:32PM -0400, David Thompson wrote: >> * gnu/packages/xxhash.scm: New file. > > I am usually not in favour of adding new files for small utilities. Could it > go somewhere else? I don't like it either, but there's no existing module that makes sense. Can anyone think of one? It this tool created cryptographic hashes then I would have put it in crypto.scm. > >> + (synopsis "Extremely fast non-cryptographic hash algorithm") >> + (description >> + "xxHash is an extremely fast hash algorithm, running at RAM speed limits. >> +It successfully passes the SMHasher test suite evaluating hash quality.") > > Maybe drop the marketing parts "extremely fast"? Okay. -- David Thompson Web Developer - Free Software Foundation - http://fsf.org GPG Key: 0FF1D807 Support the FSF: https://fsf.org/donate