From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: PATCH: LibreOffice
Date: Thu, 04 Jun 2015 22:37:47 +0200
Message-ID: <873827ryzo.fsf@gnu.org>
References: <20150531090831.GA4344@debian> <87pp5gtzi1.fsf@netris.org>
	<20150601195015.GA6191@debian> <20150601195656.GA6558@debian>
	<20150603123907.GA22264@debian.math.u-bordeaux1.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47924)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Z0bti-0005uW-6Y
	for guix-devel@gnu.org; Thu, 04 Jun 2015 16:37:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Z0bte-0004oy-Tr
	for guix-devel@gnu.org; Thu, 04 Jun 2015 16:37:54 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39912)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Z0bte-0004ot-Qo
	for guix-devel@gnu.org; Thu, 04 Jun 2015 16:37:50 -0400
In-Reply-To: <20150603123907.GA22264@debian.math.u-bordeaux1.fr> (Andreas
	Enge's message of "Wed, 3 Jun 2015 14:39:07 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Andreas Enge <andreas@enge.fr>
Cc: guix-devel@gnu.org

Andreas Enge <andreas@enge.fr> skribis:

> The good news: Patch-shebanging the external xmlsec tarball does indeed n=
ot
> seem to be necessary, so I replaced the package recipe by a simple origin
> declaration. Does this internal variable need to be mentioned in the comm=
it
> message?

Yes.

> The bad news: autoreconf is still needed for the xmlsec tarball.

Why is that?  Is it because LO=E2=80=99s own build system explicitly runs i=
t, or
because some .am or .ac file is modified?  Would be nice to mention it
in a comment.

> From 80325ab4f875ee771fa5b80d6724f2a3f3f4c80c Mon Sep 17 00:00:00 2001
> From: Andreas Enge <andreas@enge.fr>
> Date: Fri, 29 May 2015 23:49:19 +0200
> Subject: [PATCH] gnu: Add LibreOffice.
>
> * gnu/packages/libreoffice.scm (xmlsec-src-libreoffice, libreoffice):
>   New variables.
>
> Co-authored-by: John Darrington <jmd@gnu.org>

[...]

> +  (origin
> +  (method url-fetch)

Please indent fields.

> +                   (string-append "external/tarballs/"
> +                     "1f24ab1d39f4a51faf22244c94a6203f-"
> +                     "xmlsec1-1.2.14.tar.gz"))

Funny.  :-)  That name is imposed by LO=E2=80=99s build system, right?

The rest looks good to me.  OK to push with these changes.

Thanks for the hard work!

Ludo=E2=80=99.