From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mathieu Lirzin <mthl@openmailbox.org>
Subject: Re: [PATCH 02/11] gnu: Add oslotest.
Date: Thu, 16 Jul 2015 13:10:42 +0200
Message-ID: <87380ofjd9.fsf@openmailbox.org>
References: <1437003151-23838-1-git-send-email-tipecaml@gmail.com>
	<1437003151-23838-3-git-send-email-tipecaml@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52515)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mthl@openmailbox.org>) id 1ZFh5h-0008Uu-1W
	for guix-devel@gnu.org; Thu, 16 Jul 2015 07:12:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mthl@openmailbox.org>) id 1ZFh5c-0008Nt-UZ
	for guix-devel@gnu.org; Thu, 16 Jul 2015 07:12:36 -0400
Received: from smtp17.openmailbox.org ([62.4.1.51]:58860)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mthl@openmailbox.org>) id 1ZFh5c-0008M2-N1
	for guix-devel@gnu.org; Thu, 16 Jul 2015 07:12:32 -0400
In-Reply-To: <1437003151-23838-3-git-send-email-tipecaml@gmail.com> (Cyril
	Roelandt's message of "Thu, 16 Jul 2015 01:32:22 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org

Hi,

I've not test it but I have some stylistic remarks :). Most of them apply
to other parts of your patch and to the other patches.

Cyril Roelandt <tipecaml@gmail.com> writes:

> +(define-public python-mox3
> +  (package
> +  (name "python-mox3")
     ^
It should be indent under the first 'a'.

> +      (uri (string-append
> +             "https://pypi.python.org/packages/source/m/mox3/mox3-"
> +             version
> +             ".tar.gz"))
                ^
In Emacs the indentation is made under the "s" of string-append, but what
about something more compact like this:

   (uri (string-append "https://pypi.python.org/packages/source/m/"
                       "mox3/mox3-" version ".tar.gz"))

> +   `(#:tests? #f)) ;; Circular dependency with python-oslotest
                      ^^
only one ';' should be used for comments on the same line.

> +;; Packages from the Oslo library
> +(define-public python-oslotest

--8<---------------cut here---------------start------------->8---

;;;
;;; Packages from the Oslo library.
;;;

(define-public python-oslotest
--8<---------------cut here---------------end--------------->8---


> +        ("python-six" ,python-six)))
> +    (inputs
> +      `(("python-pbr" ,python-pbr)
                    ^^^
> +        ("python-mox3" ,python-mox3)
> +        ("python-os-client-config" ,python-os-client-config)
> +        ("python-setuptools" ,python-setuptools)
> +        ("python-subunit" ,python-subunit)
> +        ("python-testrepository" ,python-testrepository)
> +        ("python-testscenarios" ,python-testscenarios)
> +        ("python-testtools" ,python-testtools)))

Since the rest is ordered lexicographically... :)

> +  (home-page "http://github.com/ActiveState/appdirs")
> +  (synopsis
> +    "A small Python module for determining appropriate \" +         \"platform-specific dirs, e.g. a \"user data dir\".")
> +  (description
> +    "A small Python module for determining appropriate \" +         \"platform-specific dirs, e.g. a \"user data dir\".")

I guess this is something not intentional.

--
Mathieu Lirzin