unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alex Kost <alezost@gmail.com>
To: Orchidaceae Phalaenopsis <orchid.hybrid@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] xscreenshot and imagefile
Date: Wed, 29 Jul 2015 20:48:33 +0300	[thread overview]
Message-ID: <873806vor2.fsf@gmail.com> (raw)
In-Reply-To: <CAAo+=YpRvCVZq4LZMZ6B_TyeY=sqmBGSV+PdtXEndRtiS2-ygg@mail.gmail.com> (Orchidaceae Phalaenopsis's message of "Mon, 27 Jul 2015 17:50:00 +0000")

Orchidaceae Phalaenopsis (2015-07-27 20:50 +0300) wrote:

> Hello
>
> I would like to contribute packages for two programs:
>
> * xscreenshot which takes a screenshot and saves it as .if format
> * imagefile which contains a few programs to convert .if to gif, png

Hello, thanks for contributing!

> From ee624abf3aada75b5fa234eec0b28fd5e2c561b0 Mon Sep 17 00:00:00 2001
> From: Alf Levan <orchid.hybrid@gmail.com>
> Date: Mon, 27 Jul 2015 18:34:44 +0100
> Subject: [PATCH 1/2] gnu: Add xscreenshot.
>
> * gnu/packages/suckless.scm (xscreenshot): New variable.

Please add a copyright line for yourself to "suckless.scm" in the first
patch:

;;; Copyright © 2015 Alf Levan <orchid.hybrid@gmail.com>

BTW is it "Alf Levan" (as in the commits) or "Orchidaceae Phalaenopsis"
(as in the emails)?

[...]
> +(define-public xscreenshot
> +  (package
> +    (name "xscreenshot")
> +    (version "1.0")
> +    (source (origin
> +	     (method git-fetch)
> +	     (uri (git-reference
> +		   (url "git://git.2f30.org/xscreenshot")
> +		   (commit "cb8ad23")))

I think it is better to use "1.0.cb8ad23" for version, so:

(let ((commit "cb8ad23"))
  (package ...))

See 'guix-devel' package, for example.  The same for 'imagefile'
package.

> +	     (sha256
> +	      (base32
> +	       "1sqhxybzi8mmb0jg78swp0vpbdiqhckd283k33lfffsd0lkgch88"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     '(#:tests? #f ; no tests
> +       #:make-flags (list "CC=gcc"
> +                          (string-append "PREFIX=" %output))
> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure))))
> +    (inputs
> +     `(("libx11" ,libx11)))
> +    (native-inputs `(("pkg-config" ,pkg-config)))
> +    (home-page "http://git.2f30.org/xscreenshot/")
> +    (synopsis "Make screenshot")
> +    (description
> +     "xscreenshot is a simple screenshot utility. It writes image data to stdout.")

Description lines for both packages are too long, please fill to 72-78
column.

> +    (license license:x11)))

AFAICS <http://git.2f30.org/xscreenshot/plain/LICENSE> is the same as
<http://directory.fsf.org/wiki/License:Expat>, so it should be 'expat',
not 'x11'.

[...]
> +(define-public imagefile
> +  (package
> +    (name "imagefile")
> +    (version "1.0")

This thing doesn't mention any version in the source code at all, so I
don't know, maybe just use "0.787ebb0" (with the used commit).  What do
others think?

-- 
Alex

      parent reply	other threads:[~2015-07-29 17:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-27 17:50 [PATCH] xscreenshot and imagefile Orchidaceae Phalaenopsis
2015-07-28 23:33 ` Guix-Bot
2015-08-18 15:22   ` Guix review bot Ludovic Courtès
2015-08-18 23:26     ` Cyril Roelandt
2015-08-25 21:31       ` Ludovic Courtès
2015-07-28 23:34 ` [PATCH] xscreenshot and imagefile Guix-Bot
2015-07-28 23:41 ` Guix-Bot
2015-07-28 23:42 ` Guix-Bot
2015-07-29 15:51 ` Mark H Weaver
2015-07-29 18:24   ` Alex Kost
2015-07-30  2:58   ` Mark H Weaver
2015-07-30  7:04     ` Pjotr Prins
2015-07-30 22:41       ` Cyril Roelandt
2015-07-31 17:59       ` Andreas Enge
2015-08-01  8:09         ` Pjotr Prins
2015-07-30  9:10     ` Mathieu Lirzin
2015-07-30 19:31     ` Packaging vs. Maintaining (was: [PATCH] xscreenshot and imagefile) Jeff Mickey
2015-07-31  1:51     ` [PATCH] xscreenshot and imagefile Mark H Weaver
2015-08-18 15:13       ` Ludovic Courtès
2015-07-29 17:48 ` Alex Kost [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873806vor2.fsf@gmail.com \
    --to=alezost@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=orchid.hybrid@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).