From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/3] emacs: Enable 'guix-build-log-mode' for build log
	files.
Date: Sun, 01 Nov 2015 18:20:59 +0100
Message-ID: <8737wp4ow4.fsf@gnu.org>
References: <878u6lza89.fsf@gmail.com> <87vb9oe1yq.fsf@gnu.org>
	<874mh6lr1p.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36586)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZswJX-0005yl-48
	for guix-devel@gnu.org; Sun, 01 Nov 2015 12:21:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZswJS-0006Og-7z
	for guix-devel@gnu.org; Sun, 01 Nov 2015 12:21:07 -0500
In-Reply-To: <874mh6lr1p.fsf@gmail.com> (Alex Kost's message of "Sat, 31 Oct
	2015 23:30:10 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org

Alex Kost <alezost@gmail.com> skribis:

> From 11fea59d41063b3511a84a0d783cfa2016ed68c4 Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Sat, 31 Oct 2015 21:36:41 +0300
> Subject: [PATCH 1/2] emacs: Add 'guix-hash-char-regexp'.
>
> * emacs/guix-utils.el (guix-hash-char-regexp): New constant.
> * emacs/guix-prettify.el (guix-prettify-regexp): Use it.

LGTM.  The only possible downside is if it noticeably slows things down,
which may be the case.  Have you seen any difference?

If it happens to be slower, I=E2=80=99m fine with the current (sloppier)
variant.

> From a9a1b1ef7c272a188745d367745f9ef4fc155be9 Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Thu, 29 Oct 2015 20:48:53 +0300
> Subject: [PATCH 2/2] emacs: Enable 'guix-build-log-mode' for build log fi=
les.
>
> * emacs/guix-build-log.el (auto-mode-alist): Add 'guix-build-log-mode'
>   to 'auto-mode-alist'.

LGTM, thanks!

Ludo=E2=80=99.