From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] build: Speed up .go compilation.
Date: Mon, 11 Jan 2016 22:05:45 +0100
Message-ID: <8737u3g72u.fsf@gnu.org>
References: <87lha3rx04.fsf@T420.taylan> <87mvsgxpef.fsf@T420.taylan>
	<87ziwgf1b4.fsf@gnu.org> <87egdqy24m.fsf@T420.taylan>
	<87bn8u76tl.fsf@gnu.org> <87pox9wjsz.fsf@T420.taylan>
	<87pox9s5uh.fsf@gnu.org> <87d1t9w419.fsf@T420.taylan>
	<87d1t9rv5d.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41285)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aIjex-0003dd-88
	for guix-devel@gnu.org; Mon, 11 Jan 2016 16:05:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aIjeu-0004xK-0S
	for guix-devel@gnu.org; Mon, 11 Jan 2016 16:05:51 -0500
In-Reply-To: <87d1t9rv5d.fsf@gnu.org> (Mathieu Lirzin's message of "Sun, 10
	Jan 2016 22:18:06 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Mathieu Lirzin <mthl@gnu.org>
Cc: guix-devel@gnu.org

Mathieu Lirzin <mthl@gnu.org> skribis:

>>>>  # Unset 'GUILE_LOAD_COMPILED_PATH' altogether while compiling.  Other=
wise, if
>>>>  # $GUILE_LOAD_COMPILED_PATH contains $(moduledir), we may find .go fi=
les in
>>>>  # there that are newer than the local .scm files (for instance becaus=
e the
>>>> @@ -358,14 +346,16 @@ GUILD_COMPILE_FLAGS =3D				\
>>>>  #
>>>>  # XXX: Use the C locale for when Guile lacks
>>>>  # <http://git.sv.gnu.org/cgit/guile.git/commit/?h=3Dstable-2.0&id=3De=
2c6bf3866d1186c60bacfbd4fe5037087ee5e3f>.
>>>    ^^^
>>>
>>>> -.scm.go:
>>>> -	$(AM_V_GUILEC)$(MKDIR_P) `dirname "$@"` ;			\
>>>> +%.go: make-go ; @:
>>>> +make-go: $(MODULES) guix/config.scm guix/tests.scm
>>>> +	@echo "Compiling Scheme modules..." ;				\
>>>>  	unset GUILE_LOAD_COMPILED_PATH ;				\
>>>>  	LC_ALL=3DC							\
>>>         ^^^
>>>
>>> This is present because (scripts compile) from "old" Guile doesn't do it
>>> automatically.  What about copying the code from the link above in
>>> compile-all.scm and removing this from Makefile.am ?
>>
>> I should be using the whole (catch ...) expression, right?  Done, thanks
>> for the heads up.
>
> Yes I suppose.  Maybe Ludo can confirm?

It=E2=80=99s unnecessary to even call =E2=80=98setlocale=E2=80=99 in compil=
e-all.scm because we
don=E2=80=99t rely on anything locale-specific.  So there=E2=80=99s no prob=
lem.

The LC_ALL=3DC line can also be removed from Makefile.am.

Ludo=E2=80=99.