Re: [PATCH] build: Speed up .go compilation.

[ludo@gnu.org (Ludovic Courtès)]

Mathieu Lirzin <mthl@gnu.org> skribis:

>>>>  # Unset 'GUILE_LOAD_COMPILED_PATH' altogether while compiling.  Otherwise, if
>>>>  # $GUILE_LOAD_COMPILED_PATH contains $(moduledir), we may find .go files in
>>>>  # there that are newer than the local .scm files (for instance because the
>>>> @@ -358,14 +346,16 @@ GUILD_COMPILE_FLAGS =				\
>>>>  #
>>>>  # XXX: Use the C locale for when Guile lacks
>>>>  # <http://git.sv.gnu.org/cgit/guile.git/commit/?h=stable-2.0&id=e2c6bf3866d1186c60bacfbd4fe5037087ee5e3f>.
>>>    ^^^
>>>
>>>> -.scm.go:
>>>> -	$(AM_V_GUILEC)$(MKDIR_P) `dirname "$@"` ;			\
>>>> +%.go: make-go ; @:
>>>> +make-go: $(MODULES) guix/config.scm guix/tests.scm
>>>> +	@echo "Compiling Scheme modules..." ;				\
>>>>  	unset GUILE_LOAD_COMPILED_PATH ;				\
>>>>  	LC_ALL=C							\
>>>         ^^^
>>>
>>> This is present because (scripts compile) from "old" Guile doesn't do it
>>> automatically.  What about copying the code from the link above in
>>> compile-all.scm and removing this from Makefile.am ?
>>
>> I should be using the whole (catch ...) expression, right?  Done, thanks
>> for the heads up.
>
> Yes I suppose.  Maybe Ludo can confirm?

It’s unnecessary to even call ‘setlocale’ in compile-all.scm because we
don’t rely on anything locale-specific.  So there’s no problem.

The LC_ALL=C line can also be removed from Makefile.am.

Ludo’.