unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Fix jellyfish on non-x86_64
Date: Sat, 27 Feb 2016 22:02:24 +0100	[thread overview]
Message-ID: <8737sdeujj.fsf@mdc-berlin.de> (raw)
In-Reply-To: <20160227222227.4a84eb99@debian-netbook>


Efraim Flashner <efraim@flashner.co.il> writes:

> On Sat, 27 Feb 2016 17:10:07 +0100
> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:
>
>> * gnu/packages/bioinformatics.scm (jellyfish)[arguments]: Append
>>   "--with-sse=no" and "--with-int128=no" to configure flags unless the
>>   system is x86_64.
>> ---
>>  gnu/packages/bioinformatics.scm | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>> 
>> diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
>> index 7b3838d..36bcfd4 100644
>> --- a/gnu/packages/bioinformatics.scm
>> +++ b/gnu/packages/bioinformatics.scm
>> @@ -1984,7 +1984,11 @@ experiments and provide highly stable thresholds based on reproducibility.")
>>         (list (string-append "--enable-ruby-binding="
>>                              (assoc-ref %outputs "ruby"))
>>               (string-append "--enable-python-binding="
>> -                            (assoc-ref %outputs "python")))
>> +                            (assoc-ref %outputs "python"))
>> +             ,@(let ((system (or (%current-target-system) (%current-system))))
>> +                 (if (string-prefix? "x86_64" system)
>> +                     '()
>> +                    '("--with-sse=no" "--with-int128=no"))))
>                        ^^
> this looks like it's spaced off by 1

Oh, indeed.  Fixed.
Is the general idea okay, though?

~~ Ricardo

  reply	other threads:[~2016-02-27 21:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-27 16:10 [PATCH] Fix jellyfish on non-x86_64 Ricardo Wurmus
2016-02-27 20:22 ` Efraim Flashner
2016-02-27 21:02   ` Ricardo Wurmus [this message]
2016-02-27 23:31 ` Andreas Enge
2016-02-28 14:47   ` Ricardo Wurmus
2016-02-28 14:52     ` Andreas Enge
2016-02-28 17:26       ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8737sdeujj.fsf@mdc-berlin.de \
    --to=ricardo.wurmus@mdc-berlin.de \
    --cc=efraim@flashner.co.il \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).