unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Andreas Enge <andreas@enge.fr>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add bash-tap.
Date: Fri, 18 Mar 2016 21:49:01 +0100	[thread overview]
Message-ID: <8737rnms02.fsf@gnu.org> (raw)
In-Reply-To: <20160318185339.GA20746@solar> (Andreas Enge's message of "Fri, 18 Mar 2016 19:53:39 +0100")

Andreas Enge <andreas@enge.fr> skribis:

> I had a look (without having much experience with the trivial build system),
> and it looks mostly clean. However, the package installs three bash scripts
> that start with "#!/bin/bash". This will not work on GuixSD, where only
> /bin/sh exists. It should be patched by adding bash as an input and
> substituting. Alternatively, you could use the gnu-build-system, delete most
> of the phases, set #:tests? to #f and add a custom install phase; then the
> patch-shebangs phase will do its magic.

Alternately, the builder could manually invoke the ‘patch-shebangs’
phase, which is a regular procedure:

  (use-modules (guix build gnu-build-system))

  ((assoc-ref %standard-phases 'patch-shebangs) %build-inputs
                                                %outputs)

Ludo’.

      parent reply	other threads:[~2016-03-18 20:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-17 16:08 [PATCH] gnu: Add bash-tap Roel Janssen
2016-03-18 18:43 ` Leo Famulari
2016-03-18 18:53   ` Andreas Enge
2016-03-18 19:15     ` Leo Famulari
2016-05-03 10:44       ` Roel Janssen
2016-05-06 18:07         ` Leo Famulari
2016-05-07 17:12           ` Roel Janssen
2016-03-18 20:49     ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8737rnms02.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=andreas@enge.fr \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).