[PATCH] Add GIMP plugin “fourier”.

[PATCH] Add GIMP plugin “fourier”.

[Ricardo Wurmus]

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

Hi Guix,

the attached patch adds a GIMP plugin to edit pictures in fourier
space.  Very cool!

Unfortunately, GIMP does not respect any plugin search path environment
variable, so after installation users have to edit their GIMP settings
to include “$GUIX_PROFILE/lib/gimp/2.0/plug-ins” in
“Edit->Preferences->Folders->Plug Ins”.

~~ Ricardo


[-- Attachment #2: 0001-gnu-Add-gimp-fourier.patch --]
[-- Type: text/x-patch, Size: 3454 bytes --]

From 8c2bbbc4669eff1742f416586931b7c7f2a0bd9c Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <rekado@elephly.net>
Date: Sat, 2 Apr 2016 08:12:32 +0200
Subject: [PATCH] gnu: Add gimp-fourier.

* gnu/packages/gimp.scm (gimp-fourier): New variable.
---
 gnu/packages/gimp.scm | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/gnu/packages/gimp.scm b/gnu/packages/gimp.scm
index 00feb1c..bd27943 100644
--- a/gnu/packages/gimp.scm
+++ b/gnu/packages/gimp.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2014, 2015 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2016 Ricardo Wurmus <rekado@elephly.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -19,9 +20,11 @@
 (define-module (gnu packages gimp)
   #:use-module (guix packages)
   #:use-module (guix download)
+  #:use-module (guix utils)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system glib-or-gtk)
+  #:use-module (gnu packages algebra)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gtk)
@@ -157,3 +160,53 @@ retouching, composition and authoring.  It supports all common image formats
 as well as specialized ones.  It features a highly customizable interface
 that is extensible via a plugin system.")
     (license license:gpl3+))) ; some files are lgplv3
+
+(define-public gimp-fourier
+  (package
+    (name "gimp-fourier")
+    (version "0.4.3-2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://registry.gimp.org/files/fourier-"
+                                  version ".tar.gz"))
+              (sha256
+               (base32
+                "1rpacyad678lqgxa3hh2n0zpg4azs8dpa8q079bqsl12812k9184"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f ;no tests
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)
+         (add-after 'unpack 'set-prefix
+           (lambda* (#:key outputs #:allow-other-keys)
+             ;; gimptool-2.0 does not allow us to install to any target
+             ;; directory.
+             (let ((target (string-append (assoc-ref outputs "out")
+                                          "/lib/gimp/"
+                                          (car (string-split ,(package-version gimp) #\.))
+                                          ".0/plug-ins")))
+               (substitute* "Makefile"
+                 (("\\$\\(PLUGIN_INSTALL\\) fourier")
+                  (string-append "cp fourier " target)))
+               (mkdir-p target))
+             #t)))))
+    (inputs
+     `(("fftw" ,fftw)
+       ("gimp" ,gimp)
+       ;; needed by gimp-2.0.pc
+       ("gdk-pixbuf" ,gdk-pixbuf)
+       ("cairo" ,cairo)
+       ("glib" ,glib)
+       ;; needed by gimpui-2.0.pc
+       ("gtk+" ,gtk+-2)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (home-page "http://registry.gimp.org/node/19596")
+    (synopsis "GIMP plug-in to edit image in fourier space")
+    (description
+     "This package provides a simple plug-in to apply the fourier transform on
+an image, allowing you to work with the transformed image inside GIMP.  You
+can draw or apply filters in fourier space and get the modified image with an
+inverse fourier transform.")
+    (license license:gpl3+)))
-- 
2.7.3

Re: [PATCH] Add GIMP plugin “fourier”.

[Jookia]

On Sat, Apr 02, 2016 at 08:20:54AM +0200, Ricardo Wurmus wrote:
> Hi Guix,
>
> Unfortunately, GIMP does not respect any plugin search path environment
> variable, so after installation users have to edit their GIMP settings
> to include “$GUIX_PROFILE/lib/gimp/2.0/plug-ins” in
> “Edit->Preferences->Folders->Plug Ins”.

Could we patch GIMP to do this automatically?

> ~~ Ricardo

Jookia.

Re: [PATCH] Add GIMP plugin “fourier”.

[Ricardo Wurmus]

Jookia <166291@gmail.com> writes:

> On Sat, Apr 02, 2016 at 08:20:54AM +0200, Ricardo Wurmus wrote:

>> Unfortunately, GIMP does not respect any plugin search path environment
>> variable, so after installation users have to edit their GIMP settings
>> to include “$GUIX_PROFILE/lib/gimp/2.0/plug-ins” in
>> “Edit->Preferences->Folders->Plug Ins”.
>
> Could we patch GIMP to do this automatically?

I think it’s ugly to hard-code “~/.guix-profile” because it’s not the
only possible profile.  I’d really like a more general solution that
uses an environment variable we can source from any profile’s
“etc/profile” file.

~~ Ricardo

Re: [PATCH] Add GIMP plugin “fourier”.

[Jookia]

On Sat, Apr 02, 2016 at 09:25:21AM +0200, Ricardo Wurmus wrote:
> I think it’s ugly to hard-code “~/.guix-profile” because it’s not the
> only possible profile.  I’d really like a more general solution that
> uses an environment variable we can source from any profile’s
> “etc/profile” file.

Absolutely, but we can patch GIMP to take a load path anyway can't we?

> ~~ Ricardo

Jookia.

Re: [PATCH] Add GIMP plugin “fourier”.

[Ludovic Courtès]

Ricardo Wurmus <rekado@elephly.net> skribis:

> Unfortunately, GIMP does not respect any plugin search path environment
> variable, so after installation users have to edit their GIMP settings
> to include “$GUIX_PROFILE/lib/gimp/2.0/plug-ins” in
> “Edit->Preferences->Folders->Plug Ins”.

A solution would be to add such an environment variable, indeed.

> From 8c2bbbc4669eff1742f416586931b7c7f2a0bd9c Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Sat, 2 Apr 2016 08:12:32 +0200
> Subject: [PATCH] gnu: Add gimp-fourier.
>
> * gnu/packages/gimp.scm (gimp-fourier): New variable.

LGTM!

> +    (home-page "http://registry.gimp.org/node/19596")

Time for a new importer?  :-)

Thanks,
Ludo’.