From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Matthew Jordan <matthewjordandevops@yandex.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [Patch] Tmux Themepack
Date: Sat, 11 Jun 2016 09:45:38 +0200 [thread overview]
Message-ID: <8737ok6ue5.fsf@mdc-berlin.de> (raw)
In-Reply-To: <871t46gtte.fsf@mailerver.i-did-not-set--mail-host-address--so-tickle-me>
Hi Matthew,
thank you very much for your patch! Below are some comments.
> From 9d400b025a3d60bc29b58ba0bf1301a418ba7aa2 Mon Sep 17 00:00:00 2001
> From: Matthew Jordan <matthewjordandevops@yandex.com>
> Date: Wed, 18 May 2016 18:20:30 -0400
> Subject: [PATCH] gnu: Add Tmux themepack
> * gnu/packages/tmux.scm: (tmux-themepack): New variable.
The first “:” (after “scm”) should be deleted.
> @@ -21,10 +22,16 @@
> #:use-module (guix licenses)
> #:use-module (guix packages)
> #:use-module (guix download)
> + #:use-module (guix git-download)
> + #:use-module (guix build-system trivial)
> #:use-module (guix build-system gnu)
> #:use-module (gnu packages)
> + #:use-module (gnu packages base)
> #:use-module (gnu packages libevent)
> - #:use-module (gnu packages ncurses))
> + #:use-module (gnu packages ncurses)
> + #:use-module (guix utils)
> + #:use-module (guix build utils))
> +
This may not be important, but I suggest putting the “use-module”
expressions for “(guix utils)” and “(guix build utils)” further up where
“(guix packages)” is.
> +
> +(define-public tmux-themepack
> + (package
> + (name "tmux-themepack")
> + (version "03a3728") ;; No version tags
Please see “7.6.3 Version Numbers” in the Guix manual. We use the full
commit (in a let binding) and construct a version string from it.
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/jimeh/tmux-themepack.git")
> + (commit version)))
> + (sha256
> + (base32
> + "1d3k87mq5lca042jbap5kxskjy3kg79wjhhpnm6jacbn3anc67zl"))))
> + (build-system trivial-build-system)
> + (arguments
> + `(#:modules ((guix build utils))
> + #:builder (begin
> + (use-modules (guix build utils))
> + (let* ((out (string-append
> + (assoc-ref %outputs "out") "/share/" ,name "-" ,version))
> + (env (assoc-ref %build-inputs "coreutils"))
> + (in (string-append (assoc-ref %build-inputs "source"))))
> + (copy-recursively in ".")
> + (substitute* "themepack.tmux"
> + (("#!/usr/bin/env") (string-append "#!" env "/bin/env")))
> + (mkdir-p out)
> + (copy-recursively "." out)))))
I wonder: could you use the gnu-build-system, delete the “configure” and
“build” phases, and override the “install” phase to copy the files?
Instead of running “substitute*” on “themepack.tmux” you can use the
“patch-shebang” procedure.
> + (propagated-inputs
> + `(("tmux" ,tmux)
> + ("coreutils" ,coreutils)))
Why should coreutils be propagated? And why should tmux be installed
automatically? I think “tmux” doesn’t even need to be an input at all.
> + (home-page "https://github.com/jimeh/tmux-themepack")
> + (synopsis "Pack of various Tmux themes")
How about “Collection of themes for Tmux”.
> + (description "A pack of various Tmux themes.")
Please add a description with full sentences.
Could you please send an updated patch?
Thank you!
~~ Ricardo
next prev parent reply other threads:[~2016-06-11 7:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 17:23 [Patch] Tmux Themepack Matthew Jordan
2016-06-11 7:45 ` Ricardo Wurmus [this message]
2016-06-12 20:01 ` Matthew Jordan
2016-06-18 0:00 ` Leo Famulari
2016-07-10 13:26 ` Matthew Jordan
2016-07-10 16:19 ` Leo Famulari
2016-07-10 17:56 ` Matthew Jordan
2016-07-11 8:41 ` Alex Kost
2016-07-10 14:06 ` guix revisions (Re: [Patch] Tmux Themepack) ng0
2016-07-10 15:45 ` Leo Famulari
2016-07-10 16:16 ` guix revisions ng0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737ok6ue5.fsf@mdc-berlin.de \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=guix-devel@gnu.org \
--cc=matthewjordandevops@yandex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).