From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukas Gradl Subject: Re: [PATCH] Add msgpack Date: Sat, 18 Jun 2016 22:44:16 -0500 Message-ID: <8737o9onan.fsf@openmailbox.org> References: <87wpmbuv6m.fsf@openmailbox.org> <20160606140737.GA26555@jasmine> <20160611030655.GA24837@jasmine> <87lh2b7009.fsf@openmailbox.org> <20160612001750.GA9854@jasmine> <87eg836nm3.fsf@openmailbox.org> <20160613165852.GA31846@jasmine> <20160613175910.GA6456@jasmine> <87fusbyhk7.fsf@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bETf1-0006T5-V7 for guix-devel@gnu.org; Sat, 18 Jun 2016 23:44:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bETex-0003o0-O3 for guix-devel@gnu.org; Sat, 18 Jun 2016 23:44:34 -0400 Received: from mail2.openmailbox.org ([62.4.1.33]:57297) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bETex-0003nj-Dm for guix-devel@gnu.org; Sat, 18 Jun 2016 23:44:31 -0400 In-Reply-To: <87fusbyhk7.fsf@openmailbox.org> (Lukas Gradl's message of "Fri, 17 Jun 2016 10:13:28 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org Lukas Gradl writes: > So the flags -I, -L, -l for zlib are all there for both dynamic and > static linking. But still no store reference. I think the reason why there is no reference is that msgpack uses zbuffer only for tests. Before compilation, the file only references the name "zlib" and does not mention the hash in the path of zlib in the store. During compilation (during "check"), this mere name "zlib" gets somehow resolved to the path of zlib in the store. The binary file resulting from compiling zbuffer should therefore contain a reference to zlib, which should be detectable by guix gc --references. I think however, that this binary file does not get installed as it is only used for tests. All the files that do get installed in the output path of msgpack in the store do not contain the hash part of the store-path of zlib. They only refer to zlib by name. IIUC this can not be detected by guix gc --references since it only searches for the hash part of the store-path of zlib. This is what I grasp from looking at libstore/references.cc and libstore/store-api.cc. I am not sure about this though. Best, Lukas