From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add netcat-openbsd. [v2]
Date: Fri, 24 Jun 2016 13:53:08 +0200
Message-ID: <8737o29523.fsf@gnu.org>
References: <20160622000749.GA27984@shadowwalker>
	<20160622110046.GA12755@shadowwalker> <87r3bolxyn.fsf@gnu.org>
	<20160622224315.GA17885@shadowwalker>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56189)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bGPff-0002qt-JP
	for guix-devel@gnu.org; Fri, 24 Jun 2016 07:53:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bGPfc-00005Y-BF
	for guix-devel@gnu.org; Fri, 24 Jun 2016 07:53:15 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57873)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1bGPfc-00005I-7y
	for guix-devel@gnu.org; Fri, 24 Jun 2016 07:53:12 -0400
Received: from pluto.bordeaux.inria.fr ([193.50.110.57]:48530 helo=pluto)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128)
	(Exim 4.82) (envelope-from <ludo@gnu.org>) id 1bGPfa-0007RI-Jc
	for guix-devel@gnu.org; Fri, 24 Jun 2016 07:53:10 -0400
In-Reply-To: <20160622224315.GA17885@shadowwalker> (ng0@we.make.ritual.n0.is's
	message of "Wed, 22 Jun 2016 22:43:15 +0000")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: guix-devel@gnu.org

ng0 <ng0@we.make.ritual.n0.is> skribis:

> On 2016-06-22(11:23:28PM+0200), Ludovic Court=C3=A8s wrote:
>> Hi!
>>
>> ng0 <ng0@we.make.ritual.n0.is> skribis:
>>
>> > * gnu/packages/admin.scm (netcat-openbsd): New variable.
>> > * patches/netcat-openbsd-0001-port-to-linux-with-libbsd.patch,
>> > patches/netcat-openbsd-0002-connect-timeout.patch,
>> > patches/netcat-openbsd-0003-get-sev-by-name.patch,
>> > patches/netcat-openbsd-0004-poll-hup.patch,
>> > patches/netcat-openbsd-0005-send-crlf.patch,
>> > patches/netcat-openbsd-0006-quit-timer.patch,
>> > patches/netcat-openbsd-0007-udp-scan-timeout.patch,
>> > patches/netcat-openbsd-0008-verbose-numeric-port.patch,
>> > patches/netcat-openbsd-0009-dccp-support.patch,
>> > patches/netcat-openbsd-0010-serialized-handling-multiple-clients.patch,
>> > patches/netcat-openbsd-0011-misc-failures-and-features.patch: New file=
s.
>>
>> Sorry for joining late, but I think 11 non-trivial patches is not OK (we
>> have the policy of not keeping non-trivial patches, unless they fix an
>> immediate bug or a Guix-specific issue.)
>>
>> Is there an upstream for this package?
>
> The upstream is the debian port to linux of the nc binary of OpenBSD
> (see in code comment on upstream), mentioned in the package.

I see.  Does Debian have a Git/SVN repo for this code?  It would be best
to fetch from that repo than to carry all these patches.

If that is not possible, another option is to download all these patches
using origins, which would at least make it clear where they come from:

  (package
    (name "netcat-openbsd")
    ;; =E2=80=A6
    (source (origin
              ;; =E2=80=A6
              (patches (list (origin
                               ;; =E2=80=A6
                               (uri "http://debian.org/=E2=80=A6"))
                             =E2=80=A6)))))

WDYT?

Thanks,
Ludo=E2=80=99.