[PATCH] gnu: Add python-reportlab.

[PATCH] gnu: Add python-reportlab.

[Marius Bakke]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-Add-python-reportlab.patch --]
[-- Type: text/x-patch, Size: 2006 bytes --]

From c95b25a3ad4902ccdef79c7429485a7cacc72e1c Mon Sep 17 00:00:00 2001
From: Marius Bakke <mbakke@fastmail.com>
Date: Sun, 14 Aug 2016 16:47:33 +0100
Subject: [PATCH] gnu: Add python-reportlab.

* gnu/packages/python.scm (python-reportlab, python2-reportlab): New
  variables.
---
 gnu/packages/python.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 5cc54d0..190e797 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9886,3 +9886,35 @@ relays publish about themselves.")
 
 (define-public python2-stem
   (package-with-python2 python-stem))
+
+(define-public python-reportlab
+  (package
+    (name "python-reportlab")
+    (version "3.3.0")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "reportlab" version))
+              (sha256
+               (base32
+                "0rz2pg04wnzjjm2f5a8ik9v8s54mv4xrjhv5liqjijqv6awh12gl"))))
+    (build-system python-build-system)
+    (arguments
+     ;; Prevent creation of the egg. Without this flag, various artifacts
+     ;; from the build inputs end up in the final python3 output. It also
+     ;; works around https://debbugs.gnu.org/cgi/bugreport.cgi?bug=20765 .
+     `(#:configure-flags '("--single-version-externally-managed" "--root=/")))
+    (propagated-inputs
+     `(("python-pillow" ,python-pillow)))
+    (home-page "http://www.reportlab.com")
+    (synopsis "Python library for generating PDFs and graphics")
+    (description "This is the ReportLab PDF Toolkit.  It allows rapid creation
+of rich PDF documents, and also creation of charts in a variety of bitmap and
+vector formats.")
+    (license bsd-3)
+    (properties `((python2-variant . ,(delay python2-reportlab))))))
+
+(define-public python2-reportlab
+  (package
+    (inherit (package-with-python2
+              (strip-python2-variant python-reportlab)))
+    (native-inputs `(("python2-pip" ,python2-pip)))))
-- 
2.9.2

Re: [PATCH] gnu: Add python-reportlab.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]


> From c95b25a3ad4902ccdef79c7429485a7cacc72e1c Mon Sep 17 00:00:00 2001
> From: Marius Bakke <mbakke@fastmail.com>
> Date: Sun, 14 Aug 2016 16:47:33 +0100
> Subject: [PATCH] gnu: Add python-reportlab.
>
> * gnu/packages/python.scm (python-reportlab, python2-reportlab): New
>   variables.
> ---
>  gnu/packages/python.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)

Oops, forgot copyright line. New patch below. Perhaps pdf.scm is better?


[-- Attachment #2: 0001-gnu-Add-python-reportlab.patch --]
[-- Type: text/x-patch, Size: 2357 bytes --]

From a24bafef4b21dcdaff8b6e428a7a399eb6f5e8fd Mon Sep 17 00:00:00 2001
From: Marius Bakke <mbakke@fastmail.com>
Date: Sun, 14 Aug 2016 16:47:33 +0100
Subject: [PATCH] gnu: Add python-reportlab.

* gnu/packages/python.scm (python-reportlab, python2-reportlab): New
  variables.
---
 gnu/packages/python.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 5cc54d0..29ea9d5 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -24,6 +24,7 @@
 ;;; Copyright © 2016 Sou Bunnbu <iyzsong@gmail.com>
 ;;; Copyright © 2016 Troy Sankey <sankeytms@gmail.com>
 ;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
+;;; Copyright © 2016 Marius Bakke <mbakke@fastmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -9886,3 +9887,35 @@ relays publish about themselves.")
 
 (define-public python2-stem
   (package-with-python2 python-stem))
+
+(define-public python-reportlab
+  (package
+    (name "python-reportlab")
+    (version "3.3.0")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "reportlab" version))
+              (sha256
+               (base32
+                "0rz2pg04wnzjjm2f5a8ik9v8s54mv4xrjhv5liqjijqv6awh12gl"))))
+    (build-system python-build-system)
+    (arguments
+     ;; Prevent creation of the egg. Without this flag, various artifacts
+     ;; from the build inputs end up in the final python3 output. It also
+     ;; works around https://debbugs.gnu.org/cgi/bugreport.cgi?bug=20765 .
+     `(#:configure-flags '("--single-version-externally-managed" "--root=/")))
+    (propagated-inputs
+     `(("python-pillow" ,python-pillow)))
+    (home-page "http://www.reportlab.com")
+    (synopsis "Python library for generating PDFs and graphics")
+    (description "This is the ReportLab PDF Toolkit.  It allows rapid creation
+of rich PDF documents, and also creation of charts in a variety of bitmap and
+vector formats.")
+    (license bsd-3)
+    (properties `((python2-variant . ,(delay python2-reportlab))))))
+
+(define-public python2-reportlab
+  (package
+    (inherit (package-with-python2
+              (strip-python2-variant python-reportlab)))
+    (native-inputs `(("python2-pip" ,python2-pip)))))
-- 
2.9.2

Re: [PATCH] gnu: Add python-reportlab.

[Leo Famulari]

On Mon, Aug 15, 2016 at 03:01:00PM +0100, Marius Bakke wrote:
> 
> > From c95b25a3ad4902ccdef79c7429485a7cacc72e1c Mon Sep 17 00:00:00 2001
> > From: Marius Bakke <mbakke@fastmail.com>
> > Date: Sun, 14 Aug 2016 16:47:33 +0100
> > Subject: [PATCH] gnu: Add python-reportlab.
> >
> > * gnu/packages/python.scm (python-reportlab, python2-reportlab): New
> >   variables.
> > ---
> >  gnu/packages/python.scm | 32 ++++++++++++++++++++++++++++++++
> >  1 file changed, 32 insertions(+)
> 
> Oops, forgot copyright line. New patch below. Perhaps pdf.scm is better?

Looks good. I think pdf.scm is better. Can you send another patch?

> +     ;; Prevent creation of the egg. Without this flag, various artifacts
> +     ;; from the build inputs end up in the final python3 output. It also
> +     ;; works around https://debbugs.gnu.org/cgi/bugreport.cgi?bug=20765 .
> +     `(#:configure-flags '("--single-version-externally-managed" "--root=/")))

Feel free to add something to that discussion. We are starting a new
"core-updates" cycle, so it's a good time to begin implementing changes
to core components such as build systems.

Re: [PATCH] gnu: Add python-reportlab.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1501 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Mon, Aug 15, 2016 at 03:01:00PM +0100, Marius Bakke wrote:
>> 
>> > From c95b25a3ad4902ccdef79c7429485a7cacc72e1c Mon Sep 17 00:00:00 2001
>> > From: Marius Bakke <mbakke@fastmail.com>
>> > Date: Sun, 14 Aug 2016 16:47:33 +0100
>> > Subject: [PATCH] gnu: Add python-reportlab.
>> >
>> > * gnu/packages/python.scm (python-reportlab, python2-reportlab): New
>> >   variables.
>> > ---
>> >  gnu/packages/python.scm | 32 ++++++++++++++++++++++++++++++++
>> >  1 file changed, 32 insertions(+)
>> 
>> Oops, forgot copyright line. New patch below. Perhaps pdf.scm is better?
>
> Looks good. I think pdf.scm is better. Can you send another patch?

New patch attached.

>
>> +     ;; Prevent creation of the egg. Without this flag, various artifacts
>> +     ;; from the build inputs end up in the final python3 output. It also
>> +     ;; works around https://debbugs.gnu.org/cgi/bugreport.cgi?bug=20765 .
>> +     `(#:configure-flags '("--single-version-externally-managed" "--root=/")))
>
> Feel free to add something to that discussion. We are starting a new
> "core-updates" cycle, so it's a good time to begin implementing changes
> to core components such as build systems.

There are quite a few packages suffering from this, at least
python-{pillow,dendropy}. What's strange is that site.py and all
propagated /bin files end up in the python3 output, causing a mountain
of collisions. I'll have a shot at figuring out what's going on.

Thanks,
Marius


[-- Attachment #2: 0001-gnu-Add-python-reportlab.patch --]
[-- Type: text/x-patch, Size: 2415 bytes --]

From 0bcfdc9ac99911972e2d3a7dae5bd8f07a7beb03 Mon Sep 17 00:00:00 2001
From: Marius Bakke <mbakke@fastmail.com>
Date: Sun, 14 Aug 2016 16:47:33 +0100
Subject: [PATCH] gnu: Add python-reportlab.

* gnu/packages/pdf.scm (python-reportlab, python2-reportlab): New
  variables.
---
 gnu/packages/pdf.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
index 439adb9..d612ede 100644
--- a/gnu/packages/pdf.scm
+++ b/gnu/packages/pdf.scm
@@ -5,6 +5,7 @@
 ;;; Copyright © 2015 Paul van der Walt <paul@denknerd.org>
 ;;; Copyright © 2016 Roel Janssen <roel@gnu.org>
 ;;; Coypright © 2016 ng0 <ng0@we.make.ritual.n0.is>
+;;; Coypright © 2016 Marius Bakke <mbakke@fastmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -582,3 +583,35 @@ program capable of converting PDF into other formats.")
      "Xournal is an application for notetaking, sketching, keeping a journal
 using a stylus.")
     (license license:gpl2+)))
+
+(define-public python-reportlab
+  (package
+    (name "python-reportlab")
+    (version "3.3.0")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "reportlab" version))
+              (sha256
+               (base32
+                "0rz2pg04wnzjjm2f5a8ik9v8s54mv4xrjhv5liqjijqv6awh12gl"))))
+    (build-system python-build-system)
+    (arguments
+     ;; Prevent creation of the egg. Without this flag, various artifacts
+     ;; from the build inputs end up in the final python3 output. It also
+     ;; works around https://debbugs.gnu.org/cgi/bugreport.cgi?bug=20765 .
+     `(#:configure-flags '("--single-version-externally-managed" "--root=/")))
+    (propagated-inputs
+     `(("python-pillow" ,python-pillow)))
+    (home-page "http://www.reportlab.com")
+    (synopsis "Python library for generating PDFs and graphics")
+    (description "This is the ReportLab PDF Toolkit.  It allows rapid creation
+of rich PDF documents, and also creation of charts in a variety of bitmap and
+vector formats.")
+    (license bsd-3)
+    (properties `((python2-variant . ,(delay python2-reportlab))))))
+
+(define-public python2-reportlab
+  (package
+    (inherit (package-with-python2
+              (strip-python2-variant python-reportlab)))
+    (native-inputs `(("python2-pip" ,python2-pip)))))
-- 
2.9.2

Re: [PATCH] gnu: Add python-reportlab.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 839 bytes --]

Marius Bakke <mbakke@fastmail.com> writes:

> Leo Famulari <leo@famulari.name> writes:
>
>> On Mon, Aug 15, 2016 at 03:01:00PM +0100, Marius Bakke wrote:
>>> 
>>> > From c95b25a3ad4902ccdef79c7429485a7cacc72e1c Mon Sep 17 00:00:00 2001
>>> > From: Marius Bakke <mbakke@fastmail.com>
>>> > Date: Sun, 14 Aug 2016 16:47:33 +0100
>>> > Subject: [PATCH] gnu: Add python-reportlab.
>>> >
>>> > * gnu/packages/python.scm (python-reportlab, python2-reportlab): New
>>> >   variables.
>>> > ---
>>> >  gnu/packages/python.scm | 32 ++++++++++++++++++++++++++++++++
>>> >  1 file changed, 32 insertions(+)
>>> 
>>> Oops, forgot copyright line. New patch below. Perhaps pdf.scm is better?
>>
>> Looks good. I think pdf.scm is better. Can you send another patch?
>
> New patch attached.

Argh. Forgot to include python.scm. Here is an updated patch.


[-- Attachment #2: 0001-gnu-Add-python-reportlab.patch --]
[-- Type: text/x-patch, Size: 2664 bytes --]

From ea4713ae81030e2146f9c30e6bcad7e95203333c Mon Sep 17 00:00:00 2001
From: Marius Bakke <mbakke@fastmail.com>
Date: Sun, 14 Aug 2016 16:47:33 +0100
Subject: [PATCH] gnu: Add python-reportlab.

* gnu/packages/pdf.scm (python-reportlab, python2-reportlab): New
  variables.
---
 gnu/packages/pdf.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
index 439adb9..59e5523 100644
--- a/gnu/packages/pdf.scm
+++ b/gnu/packages/pdf.scm
@@ -5,6 +5,7 @@
 ;;; Copyright © 2015 Paul van der Walt <paul@denknerd.org>
 ;;; Copyright © 2016 Roel Janssen <roel@gnu.org>
 ;;; Coypright © 2016 ng0 <ng0@we.make.ritual.n0.is>
+;;; Coypright © 2016 Marius Bakke <mbakke@fastmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -49,6 +50,7 @@
   #:use-module (gnu packages curl)
   #:use-module (gnu packages pcre)
   #:use-module (gnu packages perl)
+  #:use-module (gnu packages python)
   #:use-module (gnu packages tls)
   #:use-module (srfi srfi-1))
 
@@ -582,3 +584,35 @@ program capable of converting PDF into other formats.")
      "Xournal is an application for notetaking, sketching, keeping a journal
 using a stylus.")
     (license license:gpl2+)))
+
+(define-public python-reportlab
+  (package
+    (name "python-reportlab")
+    (version "3.3.0")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "reportlab" version))
+              (sha256
+               (base32
+                "0rz2pg04wnzjjm2f5a8ik9v8s54mv4xrjhv5liqjijqv6awh12gl"))))
+    (build-system python-build-system)
+    (arguments
+     ;; Prevent creation of the egg. Without this flag, various artifacts
+     ;; from the build inputs end up in the final python3 output. It also
+     ;; works around https://debbugs.gnu.org/cgi/bugreport.cgi?bug=20765 .
+     `(#:configure-flags '("--single-version-externally-managed" "--root=/")))
+    (propagated-inputs
+     `(("python-pillow" ,python-pillow)))
+    (home-page "http://www.reportlab.com")
+    (synopsis "Python library for generating PDFs and graphics")
+    (description "This is the ReportLab PDF Toolkit.  It allows rapid creation
+of rich PDF documents, and also creation of charts in a variety of bitmap and
+vector formats.")
+    (license license:bsd-3)
+    (properties `((python2-variant . ,(delay python2-reportlab))))))
+
+(define-public python2-reportlab
+  (package
+    (inherit (package-with-python2
+              (strip-python2-variant python-reportlab)))
+    (native-inputs `(("python2-pip" ,python2-pip)))))
-- 
2.9.2

Re: [PATCH] gnu: Add python-reportlab.

[Leo Famulari]

On Tue, Aug 16, 2016 at 11:57:25AM +0100, Marius Bakke wrote:
> New patch attached.

Thanks, applied as 3fa2dc274, after prefixing the license and importing
(gnu packages python).

By the way, I saw this at the end of the install phase:

---
running install_scripts

########## SUMMARY INFO #########
################################################
#Attempting install of _rl_accel & pyHnj
#extensions from '/tmp/guix-build-python-reportlab-3.3.0.drv-0/reportlab-3.3.0/src/rl_addons/rl_accel'
################################################
################################################
#Attempting install of _renderPM
#extensions from '/tmp/guix-build-python-reportlab-3.3.0.drv-0/reportlab-3.3.0/src/rl_addons/renderPM'
will use package libart 2.3.12
# installing without freetype no ttf, sorry!
# You need to install a static library version of the freetype2 software
# If you need truetype support in renderPM
# You may need to edit setup.cfg (win32)
# or edit this file to access the library if it is installed
################################################
Downloading standard T1 font curves
Failed to download standard T1 font curves
phase `install' succeeded after 1.2 seconds
---

> >> +     ;; Prevent creation of the egg. Without this flag, various artifacts
> >> +     ;; from the build inputs end up in the final python3 output. It also
> >> +     ;; works around https://debbugs.gnu.org/cgi/bugreport.cgi?bug=20765 .
> >> +     `(#:configure-flags '("--single-version-externally-managed" "--root=/")))
> >
> > Feel free to add something to that discussion. We are starting a new
> > "core-updates" cycle, so it's a good time to begin implementing changes
> > to core components such as build systems.
> 
> There are quite a few packages suffering from this, at least
> python-{pillow,dendropy}. What's strange is that site.py and all
> propagated /bin files end up in the python3 output, causing a mountain
> of collisions. I'll have a shot at figuring out what's going on.

It would be awesome to make some progress on this.

Re: [PATCH] gnu: Add python-reportlab.

[Leo Famulari]

On Tue, Aug 16, 2016 at 03:10:12PM +0100, Marius Bakke wrote:
> Marius Bakke <mbakke@fastmail.com> writes:
> 
> > Leo Famulari <leo@famulari.name> writes:
> >
> >> On Mon, Aug 15, 2016 at 03:01:00PM +0100, Marius Bakke wrote:
> >>> 
> >>> > From c95b25a3ad4902ccdef79c7429485a7cacc72e1c Mon Sep 17 00:00:00 2001
> >>> > From: Marius Bakke <mbakke@fastmail.com>
> >>> > Date: Sun, 14 Aug 2016 16:47:33 +0100
> >>> > Subject: [PATCH] gnu: Add python-reportlab.
> >>> >
> >>> > * gnu/packages/python.scm (python-reportlab, python2-reportlab): New
> >>> >   variables.
> >>> > ---
> >>> >  gnu/packages/python.scm | 32 ++++++++++++++++++++++++++++++++
> >>> >  1 file changed, 32 insertions(+)
> >>> 
> >>> Oops, forgot copyright line. New patch below. Perhaps pdf.scm is better?
> >>
> >> Looks good. I think pdf.scm is better. Can you send another patch?
> >
> > New patch attached.
> 
> Argh. Forgot to include python.scm. Here is an updated patch.

I already did this before I saw this latest email :)