From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH] gnunet-svn, gnunet-gtk-svn
Date: Fri, 19 Aug 2016 10:13:05 +0300
Message-ID: <8737m15j0e.fsf@gmail.com>
References: <87lh0jf9fa.fsf@we.make.ritual.n0.is>
	<87lh0ikl95.fsf@we.make.ritual.n0.is> <20160801222135.GA9924@solar>
	<877fbzh8ya.fsf@we.make.ritual.n0.is>
	<878twfzcnb.fsf@we.make.ritual.n0.is>
	<CAJ98PDyiw0m8YeirCq=79bOaJd8zzqhM6LoMHDDF+g6ScmrgnQ@mail.gmail.com>
	<87fuqntg87.fsf@we.make.ritual.n0.is>
	<CAJ98PDwttLZ1QgEz1VyzrgEMCJiZ25=2priBjzBEpbY23QkMOg@mail.gmail.com>
	<87a8gvtcfj.fsf@we.make.ritual.n0.is>
	<87popqxeh7.fsf@we.make.ritual.n0.is> <20160803211025.GA9097@solar>
	<87zioqvyzw.fsf@we.make.ritual.n0.is>
	<87ziopfop5.fsf@we.make.ritual.n0.is>
	<87lh09c7li.fsf@we.make.ritual.n0.is>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40730)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1badzK-0007Wy-5B
	for guix-devel@gnu.org; Fri, 19 Aug 2016 03:13:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1badzE-00084v-4j
	for guix-devel@gnu.org; Fri, 19 Aug 2016 03:13:09 -0400
Received: from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243]:35165)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1badzD-00083k-Sz
	for guix-devel@gnu.org; Fri, 19 Aug 2016 03:13:04 -0400
Received: by mail-lf0-x243.google.com with SMTP id l89so2695916lfi.2
	for <guix-devel@gnu.org>; Fri, 19 Aug 2016 00:13:03 -0700 (PDT)
In-Reply-To: <87lh09c7li.fsf@we.make.ritual.n0.is> (ng0@we.make.ritual.n0.is's
	message of "Sun, 07 Aug 2016 08:21:29 +0000")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: ng0 <ng0@we.make.ritual.n0.is>
Cc: guix-devel <guix-devel@gnu.org>

ng0 (2016-08-07 11:21 +0300) wrote:

[...]
> +      (arguments
> +       '(#:configure-flags
> +         (list (string-append "--with-nssdir=" %output "/lib"))
> +         #:parallel-tests? #f ; parallel building is not functional
> +         #:tests? #f ; FAIL: test_testbed_logger_api
> +         #:phases
> +         ;; swap check and install phases and set paths to installed bin
> +         (modify-phases %standard-phases
> +           (add-after 'unpack 'patch-bin-sh
> +             (lambda _
> +               (and
> +                (substitute* '("bootstrap")

I think there is no point to use list here as it is a single file.

> +                  (("contrib/pogen.sh") "sh contrib/pogen.sh"))
> +                (for-each (lambda (f) (chmod f #o755))
> +                          (find-files "po" "")))))

'and' shouldn't be used in this phase as both 'substitute*' and
'for-each' do not specify the returned value, so:

  (lambda _
    (substitute* "bootstrap"
      (("contrib/pogen.sh") "sh contrib/pogen.sh"))
    (for-each (lambda (f) (chmod f #o755))
              (find-files "po" ""))
    #t)

I didn't build this package, I was just passing by and noticed those
small things.  I hope someone else will review and commit this patch :-)

-- 
Alex