From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add rpc-daemon service
Date: Mon, 05 Sep 2016 22:44:28 +0200
Message-ID: <8737levzyr.fsf@gnu.org>
References: <871t11kr86.fsf@gnu.org>
	<1473103331-25267-1-git-send-email-jmd@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48213)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bh0ku-0004Zr-4c
	for guix-devel@gnu.org; Mon, 05 Sep 2016 16:44:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bh0kp-0005Ee-WA
	for guix-devel@gnu.org; Mon, 05 Sep 2016 16:44:35 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44707)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1bh0kp-0005EW-Sp
	for guix-devel@gnu.org; Mon, 05 Sep 2016 16:44:31 -0400
In-Reply-To: <1473103331-25267-1-git-send-email-jmd@gnu.org> (John
	Darrington's message of "Mon, 5 Sep 2016 21:22:11 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org

John Darrington <jmd@gnu.org> skribis:

> * gnu/services/nfs.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.

[...]

> +@cindex rpcbind
> +@subsubheading Rpcbind Service

s/Rpcbind/RPC Bind/
Also move the @cindex line after @subsubheading.

> +The @code{(gnu services rpcbind)} module provides the following service.
> +
> +@deffn {Scheme Procedure} rpcbind-service [#:rpcbind rpcbind] @
> +       [#:warm-start? #t]

This procedure no longer exists.  :-)

So instead, you need to add an @defvr for =E2=80=98rpcbind-service-type=E2=
=80=99 and an
@deftp for =E2=80=98rpcbind-configuration=E2=80=99, and a couple of sentenc=
es to glues
them together (see =E2=80=9CScheduled Job Execution=E2=80=9D for an example=
.)

> +(define (rpcbind-shepherd-service config)
> +  (define pkg
> +    (rpcbind-configuration-rpcbind config))
> +
> +  (define rpcbind-command
> +    #~(list (string-append #$pkg "/bin/rpcbind") "-f"
> +            #$@(if (rpcbind-configuration-warm-start? config) '("-w") '(=
))))
> +=20=20
> +  (list (shepherd-service
> +         (provision '(rpcbind-daemon))
> +         (requirement '(networking))
> +         (start #~(make-forkexec-constructor #$rpcbind-command))
> +         (stop #~(make-kill-destructor)))))
> +
> +(define rpcbind-service-type
> +  (service-type
> +   (name 'rpcbind)
> +   (extensions (list (service-extension shepherd-root-service-type
> +                                        rpcbind-shepherd-service)))))

Better use =E2=80=98shepherd-service-type=E2=80=99 here, as noted at
<https://lists.gnu.org/archive/html/guix-devel/2016-09/msg00271.html>.

And then we=E2=80=99re done.  Could you send an updated patch?

Thank you for your patience!

Ludo=E2=80=99.