From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH 2/3] gnu: Add wcslib Date: Mon, 12 Sep 2016 16:44:44 +0300 Message-ID: <8737l58c6r.fsf@gmail.com> References: <1472584872-19300-1-git-send-email-jmd@gnu.org> <1472584872-19300-2-git-send-email-jmd@gnu.org> <874m61fngt.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43428) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjRYX-0000PJ-34 for guix-devel@gnu.org; Mon, 12 Sep 2016 09:45:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjRYS-0000uC-33 for guix-devel@gnu.org; Mon, 12 Sep 2016 09:45:52 -0400 In-Reply-To: <874m61fngt.fsf@gmail.com> (Alex Kost's message of "Wed, 31 Aug 2016 09:42:58 +0300") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: John Darrington Cc: guix-devel@gnu.org Alex Kost (2016-08-31 09:42 +0300) wrote: > John Darrington (2016-08-30 22:21 +0300) wrote: > >> * gnu/packages/astronomy.scm (wcslib): New variable. >> --- >> gnu/packages/astronomy.scm | 27 +++++++++++++++++++++++++++ >> 1 file changed, 27 insertions(+) >> >> >> diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm >> index 881e549..53e86c8 100644 >> --- a/gnu/packages/astronomy.scm >> +++ b/gnu/packages/astronomy.scm >> @@ -51,3 +51,30 @@ provides many advanced features for manipulating and filtering the information >> in FITS files.") >> (license (license:non-copyleft "file://License.txt" >> "See License.txt in the distribution.")))) >> + >> +(define-public wcslib >> + (package >> + (name "wcslib") >> + (version "5.15") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (string-append >> + "ftp://ftp.atnf.csiro.au/pub/software/wcslib/" name "-" version ".tar.bz2")) > > As for me, this line is too long, I would write: > > (uri (string-append > "ftp://ftp.atnf.csiro.au/pub/software/wcslib/" > name "-" version ".tar.bz2")) > >> + (sha256 >> + (base32 "1s2nig327g4bimd9xshlk11ww09a7mrjmsbpdcd8smsmn2kl1glb")))) >> + (inputs >> + `(("cfitsio" ,cfitsio))) >> + (build-system gnu-build-system) >> + (arguments >> + `(#:phases (modify-phases %standard-phases >> + (add-before 'configure 'patch-/bin/sh >> + (lambda _ >> + (substitute* "makedefs.in" >> + (("/bin/sh") "sh"))))))) > > This phase should end with #t. I've noticed that you didn't fix these things (long line and #t after substitute*). Could please do it next time :-) The same for 'cfitsio' package. -- Alex