From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 01/15] gnu: chez-scheme: Add search-path and fix i686
	build.
Date: Mon, 17 Oct 2016 15:34:08 +0200
Message-ID: <8737jvaylr.fsf@gnu.org>
References: <CAKrPhPPyffKpJvjxn=8bvMsxoncYv_gQ8ac13f3O8hA-0nnVdQ@mail.gmail.com>
	<878ttognhp.fsf@elephly.net>
	<CAKrPhPNc_=Tx_cp+q4MKvfj3NYOoBBNc51AUuyq=1sFCdiOgRg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40442)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bw83V-0002ea-3v
	for guix-devel@gnu.org; Mon, 17 Oct 2016 09:34:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bw83R-0006p8-G4
	for guix-devel@gnu.org; Mon, 17 Oct 2016 09:34:17 -0400
In-Reply-To: <CAKrPhPNc_=Tx_cp+q4MKvfj3NYOoBBNc51AUuyq=1sFCdiOgRg@mail.gmail.com>
	(Federico Beffa's message of "Mon, 17 Oct 2016 09:15:46 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Federico Beffa <beffa@ieee.org>
Cc: Guix-devel <guix-devel@gnu.org>

Hello Federico,

Federico Beffa <beffa@ieee.org> skribis:

> On Sun, Oct 16, 2016 at 8:25 PM, Ricardo Wurmus <rekado@elephly.net> wrot=
e:

[...]

>> Could you separate these different changes into different patches,
>> please?
>
> I've split them.

Thanks for taking the time.

> From c25b941dc4a0b5d04a871edb590a728b6075b081 Mon Sep 17 00:00:00 2001
> From: Federico Beffa <beffa@fbengineering.ch>
> Date: Mon, 17 Oct 2016 08:52:48 +0200
> Subject: [PATCH 01/17] gnu: chez-scheme: Add search-path.
>
> * gnu/packages/scheme.scm (chez-scheme): Do it.

Rather: =E2=80=A6 (chez-scheme)[native-search-paths]: New field.

Otherwise OK!

> From 7875840eb0f0d0d844da40735faabd10b791f0dd Mon Sep 17 00:00:00 2001
> From: Federico Beffa <beffa@fbengineering.ch>
> Date: Mon, 17 Oct 2016 09:01:11 +0200
> Subject: [PATCH 02/17] gnu: chez-scheme: Fix i686 build.
>
> * gnu/packages/scheme.scm (chez-scheme): Add 'configure-flags', generalize
>   'configure' phase and simplify 'install-doc' phase.

These two parts are still logically unrelated; it=E2=80=99s best if you can
split, but OK for this time.

LGTM.

> From 0f2766f86058762443645583b491fb9097a510a3 Mon Sep 17 00:00:00 2001
> From: Federico Beffa <beffa@fbengineering.ch>
> Date: Mon, 17 Oct 2016 09:05:39 +0200
> Subject: [PATCH 03/17] gnu: chez-scheme: Move to new module.
>
> * gnu/packages/scheme.scm (chez-scheme, nanopass, stex): Move variables .=
..
> * gnu/packages/chez.scm (chez-scheme, nanopass, stex): ... here. New modu=
le.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add new file.

OK!

Thank you!

Ludo=E2=80=99.