From: Mark H Weaver <mhw@netris.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: mupdf: Fix some security problems in bundled mujs.
Date: Sun, 15 Jan 2017 18:05:02 -0500 [thread overview]
Message-ID: <8737gjkjq9.fsf@netris.org> (raw)
In-Reply-To: <20170115204922.GB4522@jasmine> (Leo Famulari's message of "Sun, 15 Jan 2017 15:49:22 -0500")
Hi Leo,
Leo Famulari <leo@famulari.name> writes:
> From 34cc0dc9d9451d540f8733ebca2a3db54a073aa0 Mon Sep 17 00:00:00 2001
> From: Marius Bakke <mbakke@fastmail.com>
> Date: Thu, 12 Jan 2017 19:06:55 +0100
> Subject: [PATCH 1/2] gnu: mupdf: Fix CVE-2016-{10132,10133} in bundled mujs.
>
> * gnu/packages/patches/mupdf-mujs-CVE-2016-10132.patch,
> gnu/packages/patches/mupdf-mujs-CVE-2016-10133.patch: New files.
> * gnu/local.mk (dist_patch_DATA): Add them.
> * gnu/packages/pdf.scm (mupdf)[replacement]: New field.
We should indeed add a 'replacement' field to 'mupdf', but that part of
the patch seems to have gotten lost:
> diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
> index 9b3571e67..5efc5e6d1 100644
> --- a/gnu/packages/pdf.scm
> +++ b/gnu/packages/pdf.scm
> @@ -6,10 +6,11 @@
> ;;; Copyright © 2016 Roel Janssen <roel@gnu.org>
> ;;; Coypright © 2016 ng0 <ng0@we.make.ritual.n0.is>
> ;;; Coypright © 2016 Efraim Flashner <efraim@flashner.co.il>
> -;;; Coypright © 2016 Marius Bakke <mbakke@fastmail.com>
> +;;; Coypright © 2016, 2017 Marius Bakke <mbakke@fastmail.com>
> ;;; Coypright © 2016 Ludovic Courtès <ludo@gnu.org>
> ;;; Coypright © 2016 Julien Lepiller <julien@lepiller.eu>
> ;;; Copyright © 2016 Arun Isaac <arunisaac@systemreboot.net>
> +;;; Copyright © 2017 Leo Famulari <leo@famulari.name>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -538,6 +539,18 @@ line tools for batch rendering (pdfdraw), rewriting files (pdfclean),
> and examining the file structure (pdfshow).")
> (license license:agpl3+)))
>
> +(define mupdf/fixed
> + (package
> + (inherit mupdf)
> + (source
> + (origin
> + (inherit (package-source mupdf))
> + (patches
> + (append
> + (origin-patches (package-source mupdf))
> + (search-patches "mupdf-mujs-CVE-2016-10132.patch"
> + "mupdf-mujs-CVE-2016-10133.patch")))))))
> +
> (define-public qpdf
> (package
> (name "qpdf")
Also, you should probably add a "Co-authored-by:" header in the commit
log for yourself :)
Otherwise it looks good to me.
Thanks to both of you for working on it!
Mark
next prev parent reply other threads:[~2017-01-15 23:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 18:06 [PATCH] gnu: mupdf: Fix some security problems in bundled mujs Marius Bakke
2017-01-12 18:30 ` Leo Famulari
2017-01-12 19:46 ` Marius Bakke
2017-01-12 20:03 ` Leo Famulari
2017-01-13 0:59 ` Mark H Weaver
2017-01-13 17:34 ` Leo Famulari
2017-01-15 8:20 ` Mark H Weaver
2017-01-15 18:47 ` Leo Famulari
2017-01-15 19:05 ` Marius Bakke
2017-01-15 20:49 ` Leo Famulari
2017-01-15 20:56 ` Marius Bakke
2017-01-15 23:05 ` Mark H Weaver [this message]
2017-01-16 1:27 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737gjkjq9.fsf@netris.org \
--to=mhw@netris.org \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).