From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marius Bakke <mbakke@fastmail.com>
Subject: Re: [PATCH core-updates 6/6] utils: Add helper method to make files
	writable.
Date: Thu, 26 Jan 2017 22:21:20 +0100
Message-ID: <8737g54iwf.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>
References: <20170125171938.27271-1-mbakke@fastmail.com>
	<20170125171938.27271-7-mbakke@fastmail.com>
	<87lgty5ev9.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40546)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mbakke@fastmail.com>) id 1cWrU1-0004i5-IG
	for guix-devel@gnu.org; Thu, 26 Jan 2017 16:21:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mbakke@fastmail.com>) id 1cWrTv-0006NT-LZ
	for guix-devel@gnu.org; Thu, 26 Jan 2017 16:21:29 -0500
In-Reply-To: <87lgty5ev9.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Ludovic Court=C3=A8s <ludo@gnu.org> writes:

> Marius Bakke <mbakke@fastmail.com> skribis:
>
>> * gnu/build/activation.scm (make-file-writable): Move this to ...
>> * guix/build/utils.scm (make-file-writable): ... here. Export it.
>> * guix/build/gnu-build-system.scm (strip): Use it.
>
> [...]
>
>> --- a/guix/build/gnu-build-system.scm
>> +++ b/guix/build/gnu-build-system.scm
>> @@ -393,8 +393,10 @@ makefiles."
>>                       (or (elf-file? file) (ar-file? file))
>>                       (or (not debug-output)
>>                           (make-debug-file file))
>> -                     ;; Ensure libraries are writable.
>> -                     (chmod file #o755)
>> +
>> +                     ;; Ensure the file is writable.
>> +                     (make-file-writable file)
>
> The return value of =E2=80=98chmod=E2=80=99 and =E2=80=98make-file-writab=
le=E2=80=99 is unspecified, so
> you need to write:
>
>   (begin (make-file-writable file) #t)

Thanks! Somehow I missed that "and" block... :(

>
>> +(define (make-file-writable file)
>> +  "Make FILE writable for its owner.."
>                                       ^
> Take it as an opportunity to remove this extra period.  :-)
>
> Otherwise LGTM.

Pushed!

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAliKaFAACgkQoqBt8qM6
VPosMgf/cHq381ynaTagzu7dfn0vO11LnxO4ytlmnd+/Xz8YMiR3SgXII1kfYKez
Uk805RGfqRxwDQ5Ik+NNYa30Er1XoJUjOGtWeopbArfIurWdaATN9k/IOAvOb8YQ
gfV3lu3H87zgJeAmhYGXeZPLnyoZGSMHAv1CT3sOzBqQVgbnLJoKW5Aysd6NYia0
eFSCuY4frtAPZ4YmaDeF0TBnsuMQniNRzpb+d2JPldZeEuWnoyV2lU07twBcuU75
/0/8RW3iXIJznxwPgMXzK7dIY9/y+X22XnvCAxhQnnr6/xSKbZvp1RCegfSN3LGp
juZmrpOAY0ajFZcOIq5eigaLFYnmSw==
=S9DI
-----END PGP SIGNATURE-----
--=-=-=--