From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: Adding =?utf-8?Q?=E2=80=98--enable-openbsd-malloc=E2=80=99?= configure-flag to Tor. Date: Tue, 31 Jan 2017 12:07:59 +0000 Message-ID: <8737fzfn4w.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me> References: <8760kvfo3k.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44053) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cYXCq-0007Ah-Sb for guix-devel@gnu.org; Tue, 31 Jan 2017 07:06:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cYXCn-0001F6-Oh for guix-devel@gnu.org; Tue, 31 Jan 2017 07:06:40 -0500 Received: from perdizione.investici.org ([94.23.50.208]:26314) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cYXCn-0001En-FR for guix-devel@gnu.org; Tue, 31 Jan 2017 07:06:37 -0500 In-Reply-To: <8760kvfo3k.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Tobias Geerinckx-Rice , guix-devel@gnu.org ng0 writes: > Tobias Geerinckx-Rice writes: > >> Guix, >> >> On 30/01/17 23:44, Ludovic Court=C3=A8s wrote: >>> Re: [PATCH] gnu: tor: Add hardening configure-flags. >>>=20 >>> Applied, thanks. >> >> Ah, just too late :-) Although this isn't hardening-related. >> >> I'd like to also add the =E2=80=98--enable-openbsd-malloc=E2=80=99 con= figure flag to our=20 >> Tor . >> >> Since adding it, I've been able to serve more traffic more reliably on= a=20 >> memory-constrained relay =E2=80=94 without any noticable increase in l= oad. This=20 >> might be different on a SoC, although I'd suspect RAM would be the=20 >> limiting factor there too. >> >> To anyone willing to give it a try & give their opinion on the matter:= =20 >> I'd be very grateful. >> >> Kind regards, >> >> T G-R >> >> PS: Sorry, no patch, because of >> >> --=20 >> Sent from a Web browser. Excuse/enjoy my brevity. >> > > The tradeoff is more CPU load. For tor-relays I know how annoying > this can be, but I'm not sure if less RAM, more CPU is a good > idea (or any improvement) for the client-only side. > > I need to read more about this and comment again once I know > more. > --=20 > ng0 -- https://www.inventati.org/patternsinthechaos/ I try to take the www documentation of torproject with a grain of salt, they have seen some improvement but usually it's better to read the sourcecode and commits. In commit 6a17067d38679224e8f59dd486132400e6869dc6 Andrew made --enable-openbsd-mallow no longer the default, you now have to opt-in to it if I understand the short commit right. This was in June 2008. Some commit before that, and in 2012 was the last openbsd malloc related commit. It also seems to depend on glibc, at least according to some commit in 2008, tor 0.2.0 which removed the option entirely for a while (https://marc.info/?l=3Dtor-cvs&m=3D121946290600768&w=3D2). commit 6a17067d38679224e8f59dd486132400e6869dc6 Author: Andrew Lewman Date: Sat Jun 21 13:44:03 2008 +0000 with all of these fancy memory fixes, openbsd malloc appears to not be needed any more. svn:r15390 --=20 ng0 -- https://www.inventati.org/patternsinthechaos/