From: ludo@gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] profiles: Generate database file for manpages
Date: Sat, 01 Apr 2017 00:44:50 +0200 [thread overview]
Message-ID: <8737dtjcbh.fsf@gnu.org> (raw)
In-Reply-To: <87tw69538i.fsf@gmail.com> (Maxim Cournoyer's message of "Fri, 31 Mar 2017 00:12:29 -0700")
Hi Maxim,
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> Unfortunately some of the simplifications you made appear to break it
> :). I've tried your reworked patch and got the same result as you (no
> result found except when using man -K). When I use the original patch it
> works as I originally described.
Oops.
>> + (define (populate-manpages-collection-dir entries)
>> + (let ((manpages (append-map find-files entries)))
>> + (for-each (lambda (manpage)
>> + (let* ((dest-file (string-append
>> + manpages-collection-dir "/"
>> + (strip-store-file-name manpage))))
>
> Unfortunately we cannot simply use strip-store-file-name, since what
> mandb expects to find in our manpages-collection-dir is a collection of
> subdirectories such as man1, man3, man7, etc. such as would be found
> under "/usr/share/man" on a traditional distro. This change instead
> makes it look like:
>
> bazaar-2.7.0/ gdbm-1.12/ libxau-1.0.8/ ...
>
> I guess this is what broke it.
Oh, got it.
However, with this version of the patch, I get:
--8<---------------cut here---------------start------------->8---
?: 0 [+ #f 11]
ERROR: In procedure +:
ERROR: In procedure +: Wrong type argument in position 1: #f
builder for `/gnu/store/y754cn7f468yc1b0pc13cxk99fmnwwx1-manual-database.drv' failed with exit code 1
--8<---------------cut here---------------end--------------->8---
which I think is because (string-contains manpage-path "/share/man/")
returns #f.
Could you look into it?
(BTW, I find it slightly clearer to use ‘string-drop’ etc. instead of
‘substring’.)
Other than that it should be fine.
Thank you!
Ludo’.
next prev parent reply other threads:[~2017-03-31 22:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 8:35 [PATCH] profiles: Generate database file for manpages Maxim Cournoyer
2017-03-30 15:53 ` Ludovic Courtès
2017-03-31 7:12 ` Maxim Cournoyer
2017-03-31 22:44 ` Ludovic Courtès [this message]
2017-04-03 15:29 ` Maxim Cournoyer
2017-04-04 12:29 ` Ludovic Courtès
2017-04-04 14:20 ` Maxim Cournoyer
2017-04-05 0:59 ` Maxim Cournoyer
2017-04-05 7:45 ` Ludovic Courtès
2017-04-05 7:47 ` Ludovic Courtès
2017-04-05 8:09 ` Maxim Cournoyer
2017-04-05 21:00 ` Ludovic Courtès
2017-04-06 6:32 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737dtjcbh.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).