Hello Ludovic,

ludo@gnu.org (Ludovic Courtès) writes:

[...]

>> +           (lambda* (#:key inputs #:allow-other-keys)
>> +             (define (quoted-path input path)
>> +               (string-append "\"" input path "\""))
>> +             (substitute* "ui-snapshot.c"
>> +               (("\"gzip\"")
>> +                (quoted-path (assoc-ref %build-inputs "gzip")
>> +                             "/bin/gzip"))
>> +               (("\"bzip2\"")
>> +                (quoted-path (assoc-ref %build-inputs "bzip2")
>> +                             "/bin/bzip2"))
>> +               (("\"xz\"")
>> +                (quoted-path (assoc-ref %build-inputs "xz")
>> +                             "/bin/xz")))
>
> Use ‘inputs’ instead of ‘%build-inputs’ (it’s equivalent but IMO
> clearer.)
>
> Also I’d suggest “quoted-file-name” or just “quoted” instead of
> “quoted-path”.  :-)

OK, thanks.

> OK with changes along these lines, thank you!

Pushed as 91b21ba9f712bce033b717422c3d2022ffe8a70a

Oleg.