From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: Re: Patch adding POWER9 cross compile support Date: Wed, 06 Mar 2019 14:54:31 +0100 Message-ID: <8736o0hzvs.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([209.51.188.92]:40441) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1X0G-0000Vw-SE for guix-devel@gnu.org; Wed, 06 Mar 2019 08:54:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1X0F-0004CD-V0 for guix-devel@gnu.org; Wed, 06 Mar 2019 08:54:36 -0500 Received: from hera.aquilenet.fr ([2a0c:e300::1]:41530) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h1X0F-0004BX-LH for guix-devel@gnu.org; Wed, 06 Mar 2019 08:54:35 -0500 In-Reply-To: (Tobias Platen's message of "Wed, 27 Feb 2019 19:29:02 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Tobias Platen Cc: Guix-devel --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Tobias, Tobias Platen skribis: > I succesfully crosscompiled GNU Hello and all its dependencies > including glibc for POWER9. Without my patch glibc will fail to > build. I am using the core-updates branch, since the default branch > uses an outdated version of GCC. Awesome! What triplet did you use, is it =E2=80=9Cpowerpc9-linux-gnu=E2=80= =9D? I=E2=80=99d like to change the patch so that it doesn=E2=80=99t affect othe= r targets. Would the updated patch below work for you? Could also you succinctly explain why this flag is needed? I=E2=80=99d rat= her have a comment in the code so the next person that fiddles with it knows why it=E2=80=99s there. Thank you! Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/packages/cross-base.scm b/gnu/packages/cross-base.scm index bb3d6d916a..c70739b3ab 100644 --- a/gnu/packages/cross-base.scm +++ b/gnu/packages/cross-base.scm @@ -141,6 +141,11 @@ base compiler and using LIBC (which may be either a libc package or #f.)" "--disable-decimal-float" ;would need libc "--disable-libcilkrts" + ,@(if (string-prefix? "powerpc9-" target) + ;; On POWER9 we need this because XXX. + '("--with-long-double-128") + '()) + ;; When target is any OS other than 'none' these ;; libraries will fail if there is no libc ;; present. See --=-=-=--