Mistaken authorship on some commits

Mistaken authorship on some commits

[John Soo]

Hi Guix!

I think I am reported as the author of commits

0cc8cdbe1b0018ec37b1de9032c9eca884bedb6e
a97b943b5590c6406a85cb0f2f03fa69d7e3b7d8
c26fd5648c2a24dbd71f4c0851f8b5eced75e0f1

I did not author these, though it would have been likely.

Thank you so much, maintainers.

- John

Re: Mistaken authorship on some commits

[Tobias Geerinckx-Rice]

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

John,

Thanks for reporting this!  I'm CC'ing ngz, who pushed (or at 
least signed) all 3 commits.

John Soo 写道：
> I think I am reported as the author of commits
>
> 0cc8cdbe1b0018ec37b1de9032c9eca884bedb6e
> a97b943b5590c6406a85cb0f2f03fa69d7e3b7d8
> c26fd5648c2a24dbd71f4c0851f8b5eced75e0f1

Indeed.

> I did not author these, though it would have been likely.

Weird.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: Mistaken authorship on some commits

[Leo Famulari]

On Thu, Apr 02, 2020 at 10:03:27AM -0700, John Soo wrote:
> Hi Guix!
> 
> I think I am reported as the author of commits
> 
> 0cc8cdbe1b0018ec37b1de9032c9eca884bedb6e
> a97b943b5590c6406a85cb0f2f03fa69d7e3b7d8
> c26fd5648c2a24dbd71f4c0851f8b5eced75e0f1

If you do `git show --format=full` on these commits, it shows who
actually committed them to the repo.

I don't know what happened here, but I can say that sometimes during
patch review, the patch files don't apply so I rewrite them by hand and
then commit them with `git commit --author="Somebody else"`. I've made
similar mistakes with this workflow...

Re: Mistaken authorship on some commits

[Tobias Geerinckx-Rice]

[-- Attachment #1: Type: text/plain, Size: 897 bytes --]

Tobias Geerinckx-Rice 写道：
> Thanks for reporting this!  I'm CC'ing ngz, who pushed (or at 
> least
> signed) all 3 commits.

They answered me on IRC:

<ngz> Ah yes. I made a mistake on two commits.
<nckx> Not a disaster but would be nice to find out what happened 
and how to avoid it.
<nckx> OK.
<nckx> (3?)
<ngz> It's simple. I had to apply manually all their patches. So I 
changed the "=A" flag in Magit, and apparently, I forgot to clear 
it.
<ngz> 3? I'm only aware of "emacs-spacemacs-theme" and 
"emacs-all-the-icons".
<ngz> Oh, right, there is also "emacs-graphviz-dot-mode".
<ngz> As a side note, I have not seen any new mail from guix-devel 
since January, 8th. oO;
<nckx> All right 🙂  Magit explains a lot.  Next time do send a 
quick heads-up to guix-devel@ (and in this case the ‘author’) when 
you discover it yourself.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: Mistaken authorship on some commits

[Tobias Geerinckx-Rice]

[-- Attachment #1: Type: text/plain, Size: 618 bytes --]

Leo,

Leo Famulari 写道：
> If you do `git show --format=full` on these commits, it shows 
> who
> actually committed them to the repo.

Are you sure this isn't trivially spoofable?

Not that it would be a big deal, but ‘actually committed’ might 
give someone wrong ideas.

> I don't know what happened here, but I can say that sometimes 
> during
> patch review, the patch files don't apply so I rewrite them by 
> hand and
> then commit them with `git commit --author="Somebody 
> else"`. I've made
> similar mistakes with this workflow...

See my other reply.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: Mistaken authorship on some commits

[Tobias Geerinckx-Rice]

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

Tobias Geerinckx-Rice 写道：
>> If you do `git show --format=full` on these commits, it shows 
>> who
>> actually committed them to the repo.
>
> Are you sure this isn't trivially spoofable?
>
> Not that it would be a big deal, but ‘actually committed’ might 
> give
> someone wrong ideas.

Forgot to add: I'd recommend --show-signature for that reason.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: Mistaken authorship on some commits

[Leo Famulari]

On Thu, Apr 02, 2020 at 07:43:13PM +0200, Tobias Geerinckx-Rice wrote:
> Tobias Geerinckx-Rice 写道：
> > > If you do `git show --format=full` on these commits, it shows who
> > > actually committed them to the repo.
> > 
> > Are you sure this isn't trivially spoofable?
> > 
> > Not that it would be a big deal, but ‘actually committed’ might give
> > someone wrong ideas.
> 
> Forgot to add: I'd recommend --show-signature for that reason.

Sure, that's why we require signed commits.