From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WxoNAXrNg2BCdQEAgWs5BA (envelope-from ) for ; Sat, 24 Apr 2021 09:49:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id QmNDN3nNg2DBagAAB5/wlQ (envelope-from ) for ; Sat, 24 Apr 2021 07:49:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A5AEC1DBC0 for ; Sat, 24 Apr 2021 09:49:13 +0200 (CEST) Received: from localhost ([::1]:58228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1laD2O-00032e-QM for larch@yhetil.org; Sat, 24 Apr 2021 03:49:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55470) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1laD2G-00032X-Cw for guix-devel@gnu.org; Sat, 24 Apr 2021 03:49:04 -0400 Received: from world.peace.net ([64.112.178.59]:41664) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1laD2D-0008Km-4R for guix-devel@gnu.org; Sat, 24 Apr 2021 03:49:04 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1laD1x-0000x5-Bd; Sat, 24 Apr 2021 03:48:45 -0400 From: Mark H Weaver To: =?utf-8?Q?L=C3=A9o?= Le Bouter , Leo Famulari Subject: Re: A "cosmetic changes" commit that removes security fixes In-Reply-To: References: <87tunz11mf.fsf@netris.org> <87r1j30xmo.fsf@netris.org> <87czumypz3.fsf@netris.org> <87o8e4zy5k.fsf@gmail.com> <5cbbfa9b258fb28beb9288685ccc85b4d015cd8a.camel@zaclys.net> Date: Sat, 24 Apr 2021 03:46:57 -0400 Message-ID: <8735vgkttf.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=64.112.178.59; envelope-from=mhw@netris.org; helo=world.peace.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Guix Devel , Raghav Gururajan , Leo Prikler , Maxim Cournoyer , Sou Bunnbu Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619250553; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=08hjJgG/4pliw4zBUgdqZmjyTvh6NBOnKwKRKxQ+NIg=; b=Nhd3DydWeh6nu3Kv0chfbgU0J3sGQ+jQB0NgFg8e9/00QqUWQVdtKU68E56Y2fIlu9Td2C MfTBlnj79x9uab9/LWQgNxlJ3GXsRuWjAZddTjlrABA1NnJsEwRLDzojlwvtIX51kGXt7C /fXKXewT6Ti1SyVn6zHH2b/m7qDY/nS8NiWRq0sZBLM1o1t+mOudXNbB6AtZPj0fP4uy29 6CLLKreuB9x6qGs1dcw0NRu725oKXzuSqj6wVl93WA0znEm5Jv3tpi3t2SecPGTiXzVsh/ LJXUUi0uhsyH/VCzdNbjXzO/j0X+COIRx8ngq6gc3oo5RM1lGctO7oDq6lCZdg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619250553; a=rsa-sha256; cv=none; b=IhXkV06vLkLpijcoTjGAOwXNGi7fT6fRFM83BCGRBiDNvj18Wcr5yo5I4D6aECwzlLp4JB afTCtySADHCdM7JW6IJW+93drBKydW2fdVSfRYmV0QnekAk75aKlTfsABVW2bhMrREZcb4 oVgKiIpkWDSpuBXjz8QcqT58u9Au1qJwsF1uoeKyBtSvjD5DYHff4WkMlXQhqgw/fFmykc Y/Ag5y586vX2zqTsSygrB5dWSGa6PUpZlJazdQFV9mIfIOxbp4Smj5Jv1vrWHzRWLKNGXF hfGb8Y5GI5/QT9LyNoce051cYJE+XuaTGqUnGmB3PxlwnW+nVcommOk7zJlzRA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -0.94 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: A5AEC1DBC0 X-Spam-Score: -0.94 X-Migadu-Scanner: scn0.migadu.com X-TUID: JEHWjnh7fR52 Hi L=C3=A9o, L=C3=A9o Le Bouter writes: > On Fri, 2021-04-23 at 15:18 -0400, Leo Famulari wrote: >> L=C3=A9o and Raghav, you need to keep learning our workflow around >> security updates. It's not okay to remove security patches and later >> update a package to a fixed version in a different commit. `git >> rebase` is the tool to learn for cases like this one. > > I knew about this but I didnt feel like telling Raghav to do yet > another rebase. I felt like Raghav was taking on with so much already. This response is what native English speakers call a "red herring" : something that misleads or distracts from a relevant or important question. Why do I say that? As I pointed out elsewhere in this thread, https://lists.gnu.org/archive/html/guix-devel/2021-04/msg00366.html it appears that Raghav didn't actually remove the security fixes; it appears that *you* did. Therefore, I fail to see how it could have been avoided by asking Raghav to do another rebase. >From the IRC logs cited in the message above, it appears that you took the liberty of modifying Raghav's "cosmetic changes" commits to also remove security fixes in the re-indented packages, while claiming in the summary lines that you were "ungraft[ing]" cairo and glib. https://git.sr.ht/~lle-bout/guix/commit/a045a48dd961f0c5c3d536dcc3fd21d9c= 08d2d50 https://git.sr.ht/~lle-bout/guix/commit/6477daa338fbf1c9edacfc3690aca77ca= cfe0008 Can you please explain what went wrong here? Thanks, Mark --=20 Support Richard Stallman against the vicious disinformation campaign against him and the FSF. See for more.