* cleaning up some minor things
@ 2022-05-10 11:46 Ricardo Wurmus
2022-05-15 21:18 ` Ludovic Courtès
0 siblings, 1 reply; 3+ messages in thread
From: Ricardo Wurmus @ 2022-05-10 11:46 UTC (permalink / raw)
To: guix-devel
Hi,
“guix/scripts/pull.scm” imports WITH-FILE-LOCK/NO-WAIT from (guix build
syscalls) but doesn’t use it. Can we remove that?
“guix/store/deduplication.scm” defines a variant of DUMP-PORT with this
comment:
;; TODO: Remove once 'dump-port' in (guix build utils) has an optional 'len'
;; parameter.
The variant in (guix build utils) already supports that optional
argument. Can we remove the variant in (guix store deduplication)?
--
Ricardo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: cleaning up some minor things
2022-05-10 11:46 cleaning up some minor things Ricardo Wurmus
@ 2022-05-15 21:18 ` Ludovic Courtès
2022-05-20 20:22 ` Ricardo Wurmus
0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2022-05-15 21:18 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: guix-devel
Hello,
Ricardo Wurmus <rekado@elephly.net> skribis:
> “guix/scripts/pull.scm” imports WITH-FILE-LOCK/NO-WAIT from (guix build
> syscalls) but doesn’t use it. Can we remove that?
Yes.
> “guix/store/deduplication.scm” defines a variant of DUMP-PORT with this
> comment:
>
> ;; TODO: Remove once 'dump-port' in (guix build utils) has an optional 'len'
> ;; parameter.
>
> The variant in (guix build utils) already supports that optional
> argument. Can we remove the variant in (guix store deduplication)?
Yes, looks like it.
Go for it!
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: cleaning up some minor things
2022-05-15 21:18 ` Ludovic Courtès
@ 2022-05-20 20:22 ` Ricardo Wurmus
0 siblings, 0 replies; 3+ messages in thread
From: Ricardo Wurmus @ 2022-05-20 20:22 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
Ludovic Courtès <ludo@gnu.org> writes:
> Go for it!
Thanks for the confirmation. Done!
--
Ricardo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-20 20:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-10 11:46 cleaning up some minor things Ricardo Wurmus
2022-05-15 21:18 ` Ludovic Courtès
2022-05-20 20:22 ` Ricardo Wurmus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).