From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id GDFMHzQdpGLNdQAAbAwnHQ (envelope-from ) for ; Sat, 11 Jun 2022 06:42:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id sPRQHjQdpGJyhwAAG6o9tA (envelope-from ) for ; Sat, 11 Jun 2022 06:42:28 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3A10C2DE95 for ; Sat, 11 Jun 2022 06:42:28 +0200 (CEST) Received: from localhost ([::1]:35908 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nzsx8-0003ft-QT for larch@yhetil.org; Sat, 11 Jun 2022 00:42:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35414) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzswd-0003ff-RX for guix-devel@gnu.org; Sat, 11 Jun 2022 00:41:55 -0400 Received: from mx.kolabnow.com ([212.103.80.153]:13974) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzswa-00009B-JA; Sat, 11 Jun 2022 00:41:54 -0400 Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id 68AA04107A; Sat, 11 Jun 2022 06:41:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-transfer-encoding:content-type:content-type:mime-version :message-id:in-reply-to:date:date:subject:subject:from:from :references:received:received:received; s=dkim20160331; t= 1654922506; x=1656736907; bh=IEsx/dSlnGa3DNNI0wlmkNq9hCGjAyMrG6Z Fs8Tfopo=; b=CNt4hKuSy5wk/xt1nKw6v31vtZ5OKsm7Z9TxKOaFl8S3vLIgSug wg2hD7fmM6Nqa6jZeNyL6XSKKcX264LnCVOIUkUxiynSTEArPHBF9ie6XvgMDoU5 CCrxofQLCX4uX48U3BYWUdQ8vI+90q4oPBUw+EvPCifzFZnhsirU/fC1bTXeT13P STNGzsrtl/k5s0xocak/50BJAvW2QpWpZuTyQW0Vf7l0WA8BZarFprwdt9PfUptn lLqAIUUzK1wUn8eZRgjxQMvNI7vWixii2CeikxMX451wq4V4AkAkxlasW2aMyCAD /n4cRzRRQwbjMA4E+/tFP8GUZvCGIjK1NkwgfWoyh+IPrRhsBtcIEqvx/kemyd6p q2nVuYWUtogpCn9kMnhbPOjG3z/l8XLdlqWqkU6abC20HvGQdb8d50XiyrY4FNMe jGAqjvbA7hYJPXWNOGMrud0Or2P67hduC5e7A1w3ty+zTw1ye22q6NVPpbtSOphg 2Y6R7jAinZMPlBNmAPLjuEeU646RVgm7tJcZif+N4J/exr7gW7vcy2WR9PrKg0SZ DO/E/Zm/oi5AWCf8Qp91/bGZoAp3hKhQRsGMV0F8T+9GgEIiz8l3quGUOURLHNii sBjUDhnHpDRjz5C4fRkbF1MS11noZ8SsGdRXC1aQ6X0UIGdS9rDQG6Jk= X-Virus-Scanned: amavisd-new at mykolab.com Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out003.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H4cUKauVeXXL; Sat, 11 Jun 2022 06:41:46 +0200 (CEST) Received: from int-mx002.mykolab.com (unknown [10.9.13.2]) by mx.kolabnow.com (Postfix) with ESMTPS id 2940640D65; Sat, 11 Jun 2022 06:41:44 +0200 (CEST) Received: from ext-subm002.mykolab.com (unknown [10.9.6.2]) by int-mx002.mykolab.com (Postfix) with ESMTPS id 6EC762FBB; Sat, 11 Jun 2022 06:41:44 +0200 (CEST) References: <87ee07m77w.fsf@gnu.org> <877d5um1oe.fsf@systemreboot.net> <87tu8viix0.fsf@xelera.eu> <87bkv1lipm.fsf@systemreboot.net> <87o7z0itz3.fsf@xelera.eu> From: Thiago Jung Bauermann To: Giovanni Biscuolo Cc: Arun Isaac , GNU Guix maintainers , guix-devel@gnu.org Subject: Re: On commit access, patch review, and remaining healthy Date: Sat, 11 Jun 2022 01:13:23 -0300 In-reply-to: <87o7z0itz3.fsf@xelera.eu> Message-ID: <8735gb4xry.fsf@kolabnow.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=212.103.80.153; envelope-from=bauermann@kolabnow.com; helo=mx.kolabnow.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654922548; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=IEsx/dSlnGa3DNNI0wlmkNq9hCGjAyMrG6ZFs8Tfopo=; b=BBRlG5UmAx2AVH2SU202AxEzz6EVbsNKkJ45IfHyfiETfwZvYtXNmJlCJdi8ZHs1/iMr/S htR05HS3xPCRh2XDYI3ossqjufFxzB+GTMuVODPEGDvZKnE3i0aoLoKP/2LwixQU04dGDq 49Aurun+bWFpRFccMwKeoK6NxAlyD8wBesMtkjaDiQtulaL/RwvzrCr5d+yE8FbKmY7oWC rM5nKZk3i62dob1jxUw1Qn0de3OJ6uZyKfFJEfgPOOjhCVcXhn0lBxrrv5z6t0G4TORM5E 7WUsUPO7MPSrDE/PwJH7YE4K9Z/9aYIKFZDNgrmcgFrgD23qila2igRB6mxC9g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654922548; a=rsa-sha256; cv=none; b=TTPZg7wdmAb11x6oQei/ddIBoESYRi9/WePP/L6q2KNVQ5yzwdf+00D1CRSgypeRBgKeno XoQ7Z6WNgiyNbP4plxAp84DL1QmX534BxWGiiGLvbSBMUYPq5L0Ycuc8KQisbZrAAgsYW4 +bEQGTO6R6pCbjMPh6gWM2JO5PIP4JkAUqrevAbQ3TE/jhy6+uGGfSFmUBenWTUyav1+Qh kZeQYM/W5UhJTssp+k+L5bGoBSVKSoPtPTE6FXYyxYV603JPwxNO+aujehAeji/JRxTZZz 4rkQBF3OZ/kaYrzRW2zA9kKb790Lm6Tf4pVCtyXho/yzM1FuTJxTcTpaHcRqnQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=kolabnow.com header.s=dkim20160331 header.b=CNt4hKuS; dmarc=pass (policy=quarantine) header.from=kolabnow.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -8.98 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=kolabnow.com header.s=dkim20160331 header.b=CNt4hKuS; dmarc=pass (policy=quarantine) header.from=kolabnow.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3A10C2DE95 X-Spam-Score: -8.98 X-Migadu-Scanner: scn0.migadu.com X-TUID: zYsG4BBJpGXY Hello, Giovanni Biscuolo writes: > Arun Isaac writes: > >> - We have strict conventions for commit messages. Our commit message >> Changelog is a strange dated practice from the time before good >> version control systems. I can live with it, but not everyone likes >> it. Let's just say I've heard complaints about it offlist. > > AFAIU this is a requirement Guix inherits from GNU (being it a GNU > project) Yes, but not all projects use it anymore. For instance, GCC still does but glibc and GDB have dropped them. I couldn't figure out binutils. Some commits have them, some don't. It seems that nowadays it's more what you'd call =E2=80=9Cguidelines=E2=80=9D than actual rules=E2=80=A6 FWIW I also think they're obsolete and would prefer not to have to do them. Though most Guix patches I work on are small so it's not actually too much trouble after you get used to it. But I do think it's one more source of =E2=80=9Cfriction=E2=80=9D for new c= ontributors, and one more thing for us to require that they get right. > I don't remember the ratio for this requirement but AFAIU it made sense > to me when I read that. There's one in the GNU Coding Standards=C2=B9: Keep a change log to describe all the changes made to program source files. The purpose of this is so that people investigating bugs in the future will know about the changes that might have introduced the bug. Often a new bug can be found by looking at what was recently changed. More importantly, change logs can help you eliminate conceptual inconsistencies between different parts of a program, by giving you a history of how the conflicting concepts arose, who they came from, and why the conflicting changes were made. Personally, I think nowadays this purpose is better fulfilled by good commit messages and git blame. Especially with an editor that makes it easy to use them to navigate through history (such as Emacs, but certainly others as well). > Maybe we could help users not using Emacs with other editor-related > snippets in [~/src/guix/]etc/snippets? (I don't know other editors > templating systems) The binutils-gdb repo has a Python script to generate a skeleton ChangeLog. I don't know how well it would work for Scheme patches: https://sourceware.org/git/?p=3Dbinutils-gdb.git;a=3Dblob;f=3Dcontrib/mklog= .py;hb=3DHEAD --=20 Thanks Thiago =C2=B9 https://www.gnu.org/prep/standards/standards.html#Change-Logs