Re: 06/06: gnu: samba/fixed: Update to 4.15.13.

Re: 06/06: gnu: samba/fixed: Update to 4.15.13.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]

Hi Liliana,

guix-commits@gnu.org skriver:

> lilyp pushed a commit to branch master
> in repository guix.
>
> commit c39db91e51e55e46f177378c7b5a797441dc7d1b
> Author: Liliana Marie Prikler <liliana.prikler@gmail.com>
> AuthorDate: Sun Dec 18 08:29:07 2022 +0100
>
>     gnu: samba/fixed: Update to 4.15.13.
>     
>     * gnu/packages/samba.scm (samba/fixed-patched): New variable.
>     (samba/fixed): Add replacement for samba/fixed-patched.

[...]

>  (define-public samba/fixed
>    ;; Version that rarely changes, depended on by libsoup.
>    (hidden-package
> -   (package/inherit samba
> +   (package
> +     (inherit samba)
> +     (replacement samba/fixed-patched)
>       (version "4.15.3")

[...]

> +(define-public samba/fixed-patched
> +  (package
> +    (inherit samba/fixed)
> +    (version "4.15.13")

This is dangerous: grafts must have exactly the same store name length
since it patches binary files in-place.

I'm surprised the grafting machinery does not bail out when they differ.

I'm assuming this had security impliciations despite not being mentioned
in the commit message or comment and fixed it with
fb5514d3db19b5b405ea75cbe8fbf72d79baea1d instead of reverting.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]