unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: 01/03: gnu: sbcl: Update to 2.3.5.
       [not found] ` <20230606090539.E018EC23ED1@vcs2.savannah.gnu.org>
@ 2023-06-07 11:11   ` Christopher Baines
  2023-06-07 11:41     ` Guillaume Le Vaillant
  2023-06-08  9:18     ` Christopher Baines
  0 siblings, 2 replies; 4+ messages in thread
From: Christopher Baines @ 2023-06-07 11:11 UTC (permalink / raw)
  To: Guillaume Le Vaillant; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]


guix-commits@gnu.org writes:

> glv pushed a commit to branch master
> in repository guix.
>
> commit b019b49c74e51e42230da471f39bff9f642fbc24
> Author: Guillaume Le Vaillant <glv@posteo.net>
> AuthorDate: Fri Jun 2 13:32:55 2023 +0200
>
>     gnu: sbcl: Update to 2.3.5.
>
>     * gnu/packages/lisp.scm (sbcl): Update to 2.3.5.
> ---
>  gnu/packages/lisp.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Did this change need to go straight to master?

→ guix refresh -l sbcl
Building the following 314 packages would ensure 1615 dependent packages are rebuilt: ...

Above 300 but below 1800 means staging according to [1].

1: https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html#index-rebuild-scheduling-strategy

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: 01/03: gnu: sbcl: Update to 2.3.5.
  2023-06-07 11:11   ` 01/03: gnu: sbcl: Update to 2.3.5 Christopher Baines
@ 2023-06-07 11:41     ` Guillaume Le Vaillant
  2023-06-07 12:37       ` Christopher Baines
  2023-06-08  9:18     ` Christopher Baines
  1 sibling, 1 reply; 4+ messages in thread
From: Guillaume Le Vaillant @ 2023-06-07 11:41 UTC (permalink / raw)
  To: Christopher Baines; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 1351 bytes --]

Christopher Baines <mail@cbaines.net> skribis:

> guix-commits@gnu.org writes:
>
>> glv pushed a commit to branch master
>> in repository guix.
>>
>> commit b019b49c74e51e42230da471f39bff9f642fbc24
>> Author: Guillaume Le Vaillant <glv@posteo.net>
>> AuthorDate: Fri Jun 2 13:32:55 2023 +0200
>>
>>     gnu: sbcl: Update to 2.3.5.
>>
>>     * gnu/packages/lisp.scm (sbcl): Update to 2.3.5.
>> ---
>>  gnu/packages/lisp.scm | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Did this change need to go straight to master?
>
> → guix refresh -l sbcl
> Building the following 314 packages would ensure 1615 dependent packages are rebuilt: ...
>
> Above 300 but below 1800 means staging according to [1].
>
> 1: https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html#index-rebuild-scheduling-strategy

Currently there is no staging branch, as it got deleted because of the
changes in the branching strategy ([1]). If someone creates a staging
branch, will cuirass see that and start building it? Or could it just
stay in limbo for months?

Concerning the specific case of sbcl dependents, they build pretty fast.
On my machine, building all of them took less than one hour. So the
period during which some substitutes are missing is pretty short.

[1] https://issues.guix.gnu.org/63459

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: 01/03: gnu: sbcl: Update to 2.3.5.
  2023-06-07 11:41     ` Guillaume Le Vaillant
@ 2023-06-07 12:37       ` Christopher Baines
  0 siblings, 0 replies; 4+ messages in thread
From: Christopher Baines @ 2023-06-07 12:37 UTC (permalink / raw)
  To: Guillaume Le Vaillant; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 2474 bytes --]


Guillaume Le Vaillant <glv@posteo.net> writes:

> Christopher Baines <mail@cbaines.net> skribis:
>
>> guix-commits@gnu.org writes:
>>
>>> glv pushed a commit to branch master
>>> in repository guix.
>>>
>>> commit b019b49c74e51e42230da471f39bff9f642fbc24
>>> Author: Guillaume Le Vaillant <glv@posteo.net>
>>> AuthorDate: Fri Jun 2 13:32:55 2023 +0200
>>>
>>>     gnu: sbcl: Update to 2.3.5.
>>>
>>>     * gnu/packages/lisp.scm (sbcl): Update to 2.3.5.
>>> ---
>>>  gnu/packages/lisp.scm | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> Did this change need to go straight to master?
>>
>> → guix refresh -l sbcl
>> Building the following 314 packages would ensure 1615 dependent packages are rebuilt: ...
>>
>> Above 300 but below 1800 means staging according to [1].
>>
>> 1: https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html#index-rebuild-scheduling-strategy
>
> Currently there is no staging branch, as it got deleted because of the
> changes in the branching strategy ([1]). If someone creates a staging
> branch, will cuirass see that and start building it? Or could it just
> stay in limbo for months?

Deleting the staging branch when it's merged seems sensible to me
regardless of whether you want to use that branch in the future. As far
as I'm concerned, while there have been disucssions of changing the
branching strategy, the guidance as written down hasn't changed yet
(there are some suggested changes in [1]).

The changes in [1] still keep the 300 dependent limit on pushing changes
directly to master though.

As for the Cuirass configuration, it might need changing. You can either
ask on guix-devel/guix-sysadmin for someone to do this, or ask on
guix-sysadmin to get access to Cuirass so that you can use the admin
interface yourself [2].

2:  https://lists.gnu.org/archive/html/guix-devel/2023-06/msg00009.html

> Concerning the specific case of sbcl dependents, they build pretty fast.
> On my machine, building all of them took less than one hour. So the
> period during which some substitutes are missing is pretty short.
>
> [1] https://issues.guix.gnu.org/63459

That's still time people will be without substitutes, and because these
changes in effect "jumped the queue", that's also time the build farm
won't be building changes from patches or the branch(s) that it's meant
to be working on (since the master branch builds have priority).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: 01/03: gnu: sbcl: Update to 2.3.5.
  2023-06-07 11:11   ` 01/03: gnu: sbcl: Update to 2.3.5 Christopher Baines
  2023-06-07 11:41     ` Guillaume Le Vaillant
@ 2023-06-08  9:18     ` Christopher Baines
  1 sibling, 0 replies; 4+ messages in thread
From: Christopher Baines @ 2023-06-08  9:18 UTC (permalink / raw)
  To: Guillaume Le Vaillant; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 995 bytes --]


Christopher Baines <mail@cbaines.net> writes:

> guix-commits@gnu.org writes:
>
>> glv pushed a commit to branch master
>> in repository guix.
>>
>> commit b019b49c74e51e42230da471f39bff9f642fbc24
>> Author: Guillaume Le Vaillant <glv@posteo.net>
>> AuthorDate: Fri Jun 2 13:32:55 2023 +0200
>>
>>     gnu: sbcl: Update to 2.3.5.
>>
>>     * gnu/packages/lisp.scm (sbcl): Update to 2.3.5.
>> ---
>>  gnu/packages/lisp.scm | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Did this change need to go straight to master?

Joining this thread with a different issue, it looks like this change
has broken sbcl on armhf-linux [1].

1: https://data.guix.gnu.org/repository/1/branch/master/package/sbcl/output-history?output=out&system=armhf-linux&target=none

Maybe you tested this locally and knew of this breakage, but it would
still be good to send this for review (either as some patches or pushed
to a branch) so that it's visible to others what the effect of the
change will be.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-06-08  9:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <168604233936.6585.5956822286248744058@vcs2.savannah.gnu.org>
     [not found] ` <20230606090539.E018EC23ED1@vcs2.savannah.gnu.org>
2023-06-07 11:11   ` 01/03: gnu: sbcl: Update to 2.3.5 Christopher Baines
2023-06-07 11:41     ` Guillaume Le Vaillant
2023-06-07 12:37       ` Christopher Baines
2023-06-08  9:18     ` Christopher Baines

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).