From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id iCvRG+KLwmXtOwAAqHPOHw:P1 (envelope-from ) for ; Tue, 06 Feb 2024 20:43:30 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id iCvRG+KLwmXtOwAAqHPOHw (envelope-from ) for ; Tue, 06 Feb 2024 20:43:30 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=bayesians.ca header.s=protonmail2 header.b=hlKXYhlO; spf=pass (aspmx1.migadu.com: domain of "help-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="help-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=quarantine) header.from=bayesians.ca ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1707248610; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=7qEmovb/H6Vg/LxqzIqjLz9zmB7EWuxnuf3O55X/N1A=; b=Fi2d1WoNXauCyxSP1snbsf66PIsJJXorT+te+amO9cG2Kyacs2DTbkMfUwpeHhUq/Wn71B wv2PytaP1GgYizekcnyCrcXLs0YBzdAOVo7rzEw4jinFD0WDhgE3Vcm6lh2kGrMLj8/Uhk ISdLNTKaW8MzWLm1qs42iisbjCLeT/H5QZobDPXYQdV0Ck5alccV4tzPQ10Xf5JqHg8Hus 4QZ20RCpVBOt5krJdvezIFt0RZyNPVGJA7nUrDPisJ1Ck6TUhSyePcyaagPQXLDjUwVYUj YSIz4knon5Djk9lhNQ1jvpcz2hbgAkbceP/++ZdgS3v6i3K8kBnbJF80LuLIdg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=bayesians.ca header.s=protonmail2 header.b=hlKXYhlO; spf=pass (aspmx1.migadu.com: domain of "help-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="help-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=quarantine) header.from=bayesians.ca ARC-Seal: i=1; s=key1; d=yhetil.org; t=1707248610; a=rsa-sha256; cv=none; b=GMTtcRCbzsCm9sxByIx7+yIygOIdpYtuZz1l3E+pmpjIeqKIgZpaUJX+wHEWYuRcLB8WKw B6PZFmq+YdTbOGi44UOyUE8yvSAx5j0TDPbprU5t5tKeUN5VRcFrNRvqflfVrIOCl/LjMF 3NYmVbq0bMGrfY28PDxw3h4iqZm6/ieSbh0bfOgHXzESgnb3eaKI7sPlLX6Hp64kB6Cid1 qKEwJ5aGkjh5dnoYK0Nt2tcTVT01spV1oTu8OP9AWXzgouHunSpZxlLLocaqhWls1KEzrq JWy4f2kyGv5TJQ/wtBqvci4MEX5oqGlCjnJXiJMmEyKjEmh9exiGHUNosQYjFA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 29B2D57B49 for ; Tue, 6 Feb 2024 20:43:30 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rXRLc-0005JR-Eq; Tue, 06 Feb 2024 14:43:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXRLa-0005Iy-NZ for help-guix@gnu.org; Tue, 06 Feb 2024 14:43:10 -0500 Received: from mail-4323.proton.ch ([185.70.43.23]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXRLX-00078r-E5 for help-guix@gnu.org; Tue, 06 Feb 2024 14:43:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bayesians.ca; s=protonmail2; t=1707248582; x=1707507782; bh=7qEmovb/H6Vg/LxqzIqjLz9zmB7EWuxnuf3O55X/N1A=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=hlKXYhlOnPRs7Egkw1H4LNyOp8Y/nsxFb3hO+8cyJ40S5bVxlsFzWWS7z3s9bnass 9wdLzi4w05fDmmDhrRnudYwIftbFJJM3E+dU04Sg+FFKFjG2Jl3Y4a8bgQ8fCnRVNf XXCUxWokHw/mlJSf2rc4oSBkKo7m/mzmq8FW6MjWg81wVLVkxZ0FFoy0AXzLzy8zDb VAyNM4PWWc+SaCH8/r4LVtWDeLyLcN7KFka4nlX7EZXUAsNxNDjWBkFcvIRSC/iOxD vrPcriNqgZpXKOLcylILU57f++enMi+yBme6wbKSx93TS0l4XCbmYASTHCbVyD9LEy +WM3DIV2B+WLg== Date: Tue, 06 Feb 2024 19:42:39 +0000 To: Steve George From: Suhail Cc: Edouard Klein , guix-devel@gnu.org, help-guix@gnu.org Subject: Re: Guix Days: Patch flow discussion Message-ID: <8734u5js5w.fsf@> Feedback-ID: 38691229:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.43.23; envelope-from=suhail@bayesians.ca; helo=mail-4323.proton.ch X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, INVALID_MSGID=0.568, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: help-guix@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-guix-bounces+larch=yhetil.org@gnu.org Sender: help-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -4.95 X-Migadu-Scanner: mx13.migadu.com X-Spam-Score: -4.95 X-Migadu-Queue-Id: 29B2D57B49 X-TUID: H8uO8vC4vbJ3 Steve George writes: > elsewhere in the thread someone mentions some tags we could use > consistently so maintainers can find patches that have been reviewed > easily. It seems on the [dev manual] we already have "reviewed-looks-good" documented. Thus, I'd like to propose the below *mutually exclusive* Debbugs tag set: - "not-yet-reviewed" :: automatically set for all submissions - "reviewed-needs-fix" :: set explicitly by the reviewer - "needs-another-review" :: automatically set if there's a revised patch, unless "not-yet-reviewed" (in which case no change) - "reviewed-looks-good" :: set explicitly by the reviewer In addition to the above, it might also help for there to be an additional tag of "might-not-need-review" (or simpler, "review-not-needed") which gets automatically set, provided we implement a way to label some changes (for some packages) as being "trivial enough that they're okay as long as build succeeds". On a related note, is it possible for a reviewer who isn't a committer to set debbugs tags? [dev manual]: > It would be great to agree those - try them for a bit - and document > them in a 'howto' so that everyone uses the same process. In addition to documenting the tags in the "Debbugs Usertags" section of the manual, it would help for there to be a "howto" which focuses more on the transition between the tags (i.e., the contribution workflow). --=20 Suhail