From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id AKytDzXAIWbO7gAA62LTzQ:P1 (envelope-from ) for ; Fri, 19 Apr 2024 02:52:05 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id AKytDzXAIWbO7gAA62LTzQ (envelope-from ) for ; Fri, 19 Apr 2024 02:52:05 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Nd0ZYCoO; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1713487925; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=PRHsKg9JXDd6whahqI+LsG22sen8zpExdytzaaunJrY=; b=IwP5k7niL7yh7GyqPFFSAYWKh1kJUy5ulSRMvvHVSMQCh0eqKj1RWeISka+KsIhxvygeam JektgSeLcMtJd2V41d0ZQi/8PfWxtFACT8289HXKSHIFWv5hJ/YGh2nreWn4td8uU5WBBe 0pO2LlZGmVxZhK23eUZak2WysoGQIYZv9B9sdLL/mM0p6lQwW6R10stx+IYgBJaaHY3j72 65TsSwi5sKpp0lXCDMyMdlGb1yl1sWFW0i/V5XkjD6UWhXFkg17JeK01ITY/sbEkbHGlU8 acrFLvmbQDfCKXlu6CvhNtTj45GC5kvnMparMp0SLOWCnXbEwdrbagt9fXj6EQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1713487925; a=rsa-sha256; cv=none; b=B4fgRmnXaLvM36UxIhK9+gPLjaFZKmY77BsezczkOwcd+Sb8p5m6OygEV4S3bwoIeVGg1L 8NGfOf8pr+KocrqZcz+QCRa0c2FFNIqlLSyi47KlDc12TH+AWC2zO8NZ844VpZ3+d3H+Ik XVmGcyX2LvtZzLs2tBoUo5Ks5nkB69fl8c/oVCKjVBa2NlbM4+y4OVozy8BDqOj/obaWL9 B1hIV5dNsM50GNdb25tlKBESlIN4B0nZ/I40jUgU8mhthfRC7VWyIC06h2wEsKTAYVXtXZ yx+W9MkRmO1Cd47r1ZAsaxQqVmvOFCTbN/Jdl13pKzumZTGM/MFqWSaVv1lrrg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Nd0ZYCoO; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BDA8320067 for ; Fri, 19 Apr 2024 02:52:04 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rxcTO-0006Df-Lm; Thu, 18 Apr 2024 20:51:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxcTL-0006DW-IA for guix-devel@gnu.org; Thu, 18 Apr 2024 20:51:23 -0400 Received: from mail-ot1-x329.google.com ([2607:f8b0:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rxcTK-0001nq-4U; Thu, 18 Apr 2024 20:51:23 -0400 Received: by mail-ot1-x329.google.com with SMTP id 46e09a7af769-6eb75c202dbso739733a34.2; Thu, 18 Apr 2024 17:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713487878; x=1714092678; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PRHsKg9JXDd6whahqI+LsG22sen8zpExdytzaaunJrY=; b=Nd0ZYCoOGXYp7WHTGoXt9rvlDsvhPp1ikhvN6dhbxHkxa+kl/MQwdy4rxWqnjK90zN tbYFMxpu2QUVuE64kFDtxRFMwFLggO1mR3Czn32Hm+HUtSeCG9t28DzJ7lTWWVLccrEt 0Dr90udVu/5VaOqpJecVGAbIaO2teabe2RlOk7l4EWhe9iREoVfgKp+ampXOvNlUcMWM e7nD1ydO+89MVbFIBWJIwoPtqOtj4nNa54fHyygc7+5mf49qGVaMv6qgHb2dJtQgVmfH s911DYeNwc33tIYpse80U1u6crhCrEE9qqRHSvilHcNF5O3NzFUvxnpw49ruMj9+1mu6 jlBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713487878; x=1714092678; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PRHsKg9JXDd6whahqI+LsG22sen8zpExdytzaaunJrY=; b=mejtL5Z0RSjzb0Mc397ULw9KxjBtNSAhCKY+fltDY/HzclU4LMc82jtwq+Q0EKFtcM C+huNzkeuGVbL41TUas5kc+Ox1V2S9LO2WmN45SSme/S4HkrTCdEm6bmrrdwivMTu4Pe TIhOOcP3UzF3gdqPPxKYKNNXJLXYeTpHdGybrTSPcPIcGBi9Bf7aSu9AoxPOGVcyJAhB 180C1lDgWpLJxeJeqaSrs5MKScgm2gqy8LH145EdNep9f1i/NLvXIrmwEDg8BRtZUXAC LhryM+dZ/brgs5ZxdG3Nsxvn4Hao/BHPayEbU9eBgb6pWzFCQWP7QDiOZi74m7SwBprl h7cA== X-Gm-Message-State: AOJu0Yw6U9yKbtFDyBE1mxcWJcFT9aGk4XtjsYUuNNp3vENjJCfMq2+4 zW9vCnIzaRkOQ1XetpLK4PC2A6E+5nlWiFr8ryD+pY4uGc4bZx6KryWw4Q== X-Google-Smtp-Source: AGHT+IE1rJhG5O7BdfETWmW55BrnIx34PxOJvPy5p6zM4frd1jNSQaCqjRZHMgj5kO5c1lsBmu3a1g== X-Received: by 2002:a05:6808:648:b0:3c5:f7fc:bb90 with SMTP id z8-20020a056808064800b003c5f7fcbb90mr576384oih.39.1713487878487; Thu, 18 Apr 2024 17:51:18 -0700 (PDT) Received: from hurd (dsl-159-201.b2b2c.ca. [66.158.159.201]) by smtp.gmail.com with ESMTPSA id b21-20020a05620a127500b0078d75b9fb37sm1151231qkl.32.2024.04.18.17.51.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 17:51:17 -0700 (PDT) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Subject: Re: 01/06: gnu: gnurl: Deprecate in favor of curl. In-Reply-To: <87il0srzg8.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Mon, 08 Apr 2024 11:11:35 +0200") References: <171241884468.15036.13062380984395745916@vcs2.savannah.gnu.org> <20240406155405.34F4DC12C2D@vcs2.savannah.gnu.org> <87il0srzg8.fsf@gnu.org> Date: Thu, 18 Apr 2024 20:51:16 -0400 Message-ID: <8734rinpiz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::329; envelope-from=maxim.cournoyer@gmail.com; helo=mail-ot1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -8.19 X-Spam-Score: -8.19 X-Migadu-Queue-Id: BDA8320067 X-Migadu-Scanner: mx12.migadu.com X-TUID: 9q1spe+zVVv9 Hi Ludo, Ludovic Court=C3=A8s writes: > Hi, > > guix-commits@gnu.org skribis: > >> +(define-deprecated/public-alias gnurl curl) > > Just for the record (because it probably doesn=E2=80=99t matter much in t= his > case), this creates a deprecated alias for the variable, but not for the > package. > > For package deprecation, I think it=E2=80=99s best to write: > > (define-public gnurl (deprecated-package "gnurl" curl)) > > to allow =E2=80=9Cguix install gnurl=E2=80=9D to DTRT. Deprecating the v= ariable itself > is usually less important for packages. Ugh. I always spent some minutes looking at the docstring and they are too general/vague to be of much practical use, at least to me, and I often manage to get it wrong, as I did here! I tried to follow-up with the recommended '(define-public gnurl (deprecated-package "gnurl" curl))' alternative, but it seems I'm not hitting a Guile module top-level dependency cycle, as it won't byte compile, erroring with: --8<---------------cut here---------------start------------->8--- ice-9/eval.scm:293:34: error: curl: unbound variable --8<---------------cut here---------------end--------------->8--- Indeed, deprecated-package works by inheritance, so according to our guidelines defined in (info '(guix) Cyclic Module Dependencies'), it should be defined in the curl module. I've now done so in commit a69e5e5e47b70e3fe14040142544147fbd9239a1. > As I write this, I realize we should probably document package > deprecation and removal. This would greatly help, and/or extended docstrings with practical examples at the definition sites. --=20 Thanks, Maxim