From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id ELV8GH09cGY5BQEA62LTzQ:P1 (envelope-from ) for ; Mon, 17 Jun 2024 13:43:25 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id ELV8GH09cGY5BQEA62LTzQ (envelope-from ) for ; Mon, 17 Jun 2024 15:43:25 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=inria.fr header.s=dc header.b=jy7lvbx8; dmarc=pass (policy=none) header.from=inria.fr; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1718631805; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=DwN2m/Z6p7pMqodirS4WR7yakCoD1xgEopbKOwS1JlE=; b=HizlovBQwC6k3q4/cd90EeEXQqh3YoJxKCSIM63/VqRhBrpSLiCbotBgGC+r4vMpokalLv E9Dpv08Y5BnQgFjETaxOMLtIbHUOoNwihPGoqJ/hQJo4L9zz6+pjwP7eOaa0x38QO7RMB6 kLNKXbVpEXAcDmTATIZ0/DgofWePyyCVUkovGThwSxeR6eCxvr44MyqvBUxUlqNeyMnXBo TufsJaOt5A6+r2keS10UDnAKNAnirexlgS5L5o1OoVXOkElbLIqRU2w8jXnzcXm4TUziuw oDdNV98peoVp4myp2eWI/HKc9OIjRiywfiGBqTv+hgV84EySTqFWWhhuh3ZpIQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1718631805; a=rsa-sha256; cv=none; b=MgoAEStS7D7DOURbF9M9Nn5o5HK2dQC1LLA+Yh4BXcfeWn3YZseIbeTU7PkC+uu4mdKUtY ECv9aa1stNuaGdc0kXwPxTWNiSHBler0HGTb2qD55fKP23DXQ2nAeii/LsII3Fv4kluY5l GA9Q0WTzaQI/Lfsos3UxR13S8MWdRpUZcyF5dmPjaGbbE/nybJaPD3pcI0A/MDfT1n3Gsw 5NvB+XrJdzY3he0z67xOo1pnGMTToZOKFRAwQO4tNmPejpiO1yBlVhc430iKv0y2lM4D+X nHYZidyd+hnZLt+psgsuGProUshqRTnMQn3T1Sesycz9xwXEG5Fb53jzpTu1Lg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=inria.fr header.s=dc header.b=jy7lvbx8; dmarc=pass (policy=none) header.from=inria.fr; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 247573BCB4 for ; Mon, 17 Jun 2024 15:43:25 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJCdL-0007He-2n; Mon, 17 Jun 2024 09:42:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJCdJ-0007HR-H4 for guix-devel@gnu.org; Mon, 17 Jun 2024 09:42:53 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJCdG-0004PW-SQ for guix-devel@gnu.org; Mon, 17 Jun 2024 09:42:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=DwN2m/Z6p7pMqodirS4WR7yakCoD1xgEopbKOwS1JlE=; b=jy7lvbx8zYt0dDt0LtZgTiE51nq7GiaAhRhP2lnZ+OayEN6D6WajQY1Z m1mcCsmbzadxo1agSlkL8P9gacC+rvRqcIyw6MxC4LWabKbMN7jZh9Wux pCIGVF/FXcFaLKtvb6RwEbPVgIyIyvEgSN9A3qomE7I40Lhc4vf7CwfjI M=; X-IronPort-AV: E=Sophos;i="6.08,244,1712613600"; d="scan'208";a="171064770" Received: from 231.red-83-43-93.dynamicip.rima-tde.net (HELO ribbon) ([83.43.93.231]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2024 15:42:48 +0200 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Romain GARBAGE Cc: guix-devel@gnu.org Subject: Re: [PATCH Cuirass] cuirass: Fix handling of SPECIFICATION-NAME. In-Reply-To: <20240617124425.8410-1-romain.garbage@inria.fr> (Romain GARBAGE's message of "Mon, 17 Jun 2024 14:44:25 +0200") References: <20240617124425.8410-1-romain.garbage@inria.fr> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: =?utf-8?Q?D=C3=A9cadi?= 30 Prairial an 232 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du Chariot X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 17 Jun 2024 15:42:47 +0200 Message-ID: <8734pb7kiw.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=192.134.164.83; envelope-from=ludovic.courtes@inria.fr; helo=mail2-relais-roc.national.inria.fr X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -9.06 X-Spam-Score: -9.06 X-Migadu-Queue-Id: 247573BCB4 X-Migadu-Scanner: mx11.migadu.com X-TUID: rA69yx0WC3dG Hi! Romain GARBAGE skribis: > Fixes a regression introduced in > 1da873b0e23eceb3c239dd6dc6781debf23bec63, where the NAME field of the > SPECIFICATION record type is forced to be a symbol as stated by the > documentation. Yay, that was fast! > * src/cuirass/base.scm: Handle SPECIFICATION-NAME as a symbol. > * src/cuirass/http.scm: Handle SPECIFICATION-NAME as a symbol. > * src/cuirass/templates.scm: Fix template generation. Bonus points if you can mention the affected procedures in the message above (I can do it for you otherwise). I tested it locally following the instructions from =E2=80=98README=E2=80= =99. One case where we still get a type error is when triggering evaluation through the web interface: wget --post-data=3D"" -O/dev/null \ http://localhost:8080/jobset/random/hook/evaluate This leads to this backtrace in =E2=80=98cuirass web=E2=80=99: --8<---------------cut here---------------start------------->8--- In cuirass/http.scm: 1408:46 1 (url-handler # _ _) In ice-9/boot-9.scm: 1685:16 0 (raise-exception _ #:continuable? _) In procedure string->symbol: Wrong type argument in position 1 (expecting s= tring): random --8<---------------cut here---------------end--------------->8--- Note that this in turn causes communication with =E2=80=98cuirass register= =E2=80=99 over the =E2=80=9Cbridge=E2=80=9D, so there could be other issues there. Thanks, Ludo=E2=80=99.