From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 3/3] gnu: Add octave and dependencies
Date: Sat, 25 Jan 2014 21:41:32 +0100
Message-ID: <871tzvu743.fsf@gnu.org>
References: <1390507648-21659-1-git-send-email-jmd@gnu.org>
	<1390507648-21659-3-git-send-email-jmd@gnu.org>
	<8761p8ulih.fsf@gnu.org> <20140125161456.GA31777@jocasta.intra>
	<20140125164217.GA21259@debian> <20140125170440.GA4883@jocasta.intra>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50218)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1W7A7q-0002Vm-5k
	for guix-devel@gnu.org; Sat, 25 Jan 2014 15:46:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1W7A7g-0001gY-Dq
	for guix-devel@gnu.org; Sat, 25 Jan 2014 15:46:46 -0500
In-Reply-To: <20140125170440.GA4883@jocasta.intra> (John Darrington's message
	of "Sat, 25 Jan 2014 18:04:40 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: John Darrington <john@darrington.wattle.id.au>
Cc: guix-devel@gnu.org, John Darrington <jmd@gnu.org>

John Darrington <john@darrington.wattle.id.au> skribis:

> On Sat, Jan 25, 2014 at 05:42:17PM +0100, Andreas Enge wrote:
>      On Sat, Jan 25, 2014 at 05:14:57PM +0100, John Darrington wrote:
>      > The octave build system is rather naive.  These propagated inputs =
don't actually
>      > *need* to be present at configure/build time.  But the ./configure=
 (rather stupidly IMO)
>      > checks for their presence, and turns off the relevant features if =
they are not found.
>      > Therefore, one must declare them as native-inputs just to keep ./c=
onfigure happy AND
>      > as propagated inputs because they are called in a pipe from the oc=
tave program itself.
>=20=20=20=20=20=20
>      Would it be reasonable to patch the lines in which external programs=
 are
>      called, replacing the program name by its complete path with a well-=
chosen
>      (substitute*)?
>      Then one would not need to propagate the inputs.
>=20=20=20=20=20=20
> I don't think that will work.

I think it would.  If there=E2=80=99s a line like:

  execlp ("makeinfo" ...);

patching that to, say:

  execl ("/.../bin/makeinfo" ...);

will definitely work.  (This is what Octave=E2=80=99s build system should be
doing, actually.)

WDYT?

(As an example, see how mingetty is patched to refer to a specific
=E2=80=98login=E2=80=99 program, in admin.scm.)

Ludo=E2=80=99.