From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add gegl and gimp
Date: Thu, 03 Jul 2014 19:18:59 +0200
Message-ID: <871tu22we4.fsf@gnu.org>
References: <1404380329-3120-1-git-send-email-jmd@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38472)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1X2kf9-00080F-1I
	for guix-devel@gnu.org; Thu, 03 Jul 2014 13:19:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1X2kez-000838-VC
	for guix-devel@gnu.org; Thu, 03 Jul 2014 13:19:10 -0400
In-Reply-To: <1404380329-3120-1-git-send-email-jmd@gnu.org> (John Darrington's
	message of "Thu, 3 Jul 2014 11:38:49 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org

John Darrington <jmd@gnu.org> skribis:

> * gnu/packages/gimp.scm (gegl, gimp): New variables.

Great, looks good to me!

[...]

> +        (lambda _
> +          ;; This test program seems to crash on exit. Specifically, whi=
lst
> +          ;; g_object_unreffing bufferA and bufferB - This seems to be a=
 bug in
> +          ;; the destructor.  This is just a test program so will not ha=
ve any
> +          ;; wider effect, although might be hiding another problem.  The
> +          ;; developers view is: "No released version is expected to be
> +          ;; stable.  Use the version from git" Go figure!!
> +          (substitute* "tools/img_cmp.c"
> +            (("g_object_unref \\(buffer.\\);") ""))

Could you add a link to the discussion or PR (if any?).

> +    (arguments
> +     `(#:configure-flags=20=20=20=20=20=20=20
> +       `("--disable-python" ))) ; We don't have pygtk which seems to be =
needed for this feature

Line too long, please move the comment above.

> +    (synopsis "Image manipulation program.")

No period here.

> +    (description "GIMP is the GNU Image Manipulation Program. It is a fr=
eely
> +distributed piece of software for such tasks as photo retouching, image
> +composition and image authoring.")

Two spaces after end-of-sentence period.

> +    (license license:gpl3+))) ; Some files are LGPLv3+

Comment all lower-case, or period at the end of sentence.

OK to push with these changes!

Ludo=E2=80=99.